Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove duplicate function calls #773

Merged
merged 2 commits into from
Jul 25, 2018
Merged

perf: remove duplicate function calls #773

merged 2 commits into from
Jul 25, 2018

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Jun 11, 2018 •
edited
Loading

  • remove duplicate initialization calls in most directives
  • remove getDisplayStyle call from BaseDirective ngOnInit

Fixes #761

@CaerusKaru CaerusKaru added this to the v6.0.0-beta.17 milestone Jun 11, 2018
@CaerusKaru CaerusKaru mentioned this pull request Jun 11, 2018
Closed
@CaerusKaru CaerusKaru merged commit bc7f77f into master Jul 25, 2018
@CaerusKaru CaerusKaru deleted the adam/fix-issue-761 branch July 25, 2018 16:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ThomasBurleson ThomasBurleson

Labels
cla: yes performance pr: needs review
Projects
None yet
Milestone
v6.0.0-beta.17
Development

Successfully merging this pull request may close these issues.

Possible performance issue with double forced reflow
3 participants
@CaerusKaru @ThomasBurleson @googlebot