This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(mdInput): Fix md-maxlength when used with ng-messages.
The recently added support for input elements to have multiple messages caused a rendering issue for the `md-maxlength` character counter. Update code/CSS to properly position the character counter when used with and without ng-messages. Fixes #4783. POSSIBLE BREAKING CHANGE - The `<div class="md-char-counter">` that is automatically added to the input is now added after the input if no messages are found, but inside if they are. This may cause some styling issues if users provide custom CSS. Users may need to update their CSS to take the extra HTML into account. Example rendered HTML: **Without `ng-messages`:** ```html <label>Label is here</label> <input /> <div class="md-char-counter">10/20</div> ``` **With `ng-messages`:** ```html <label>Label is here</label> <input /> <div ng-messages="..."> <div class="md-char-counter">10/20</div> <div ng-message="requried">This is required</div> </div> ``` Closes #4786.
- Loading branch information
1 parent
64fb803
commit 968aa23
Showing
4 changed files
with
31 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters