From b983c0d4575f6701cb327f29c75354dc31447c74 Mon Sep 17 00:00:00 2001 From: Ryan Schmukler Date: Mon, 28 Sep 2015 11:52:21 -0400 Subject: [PATCH] fix(select): rollback number parsing on value attr closes #4615 As per the discussion in #4615, please use `ng-value` if you need a non-string value from an md-option for the `ng-model` of a select. --- src/components/select/select.js | 2 +- src/components/select/select.spec.js | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/components/select/select.js b/src/components/select/select.js index 4570891dfe7..1e9e0d9fba0 100755 --- a/src/components/select/select.js +++ b/src/components/select/select.js @@ -673,7 +673,7 @@ function OptionDirective($mdButtonInkRipple, $mdUtil) { if (angular.isDefined(attr.ngValue)) { scope.$watch(attr.ngValue, setOptionValue); } else if (angular.isDefined(attr.value)) { - setOptionValue(isNaN(attr.value) ? attr.value : Number(attr.value)); + setOptionValue(attr.value); } else { scope.$watch(function() { return element.text(); diff --git a/src/components/select/select.spec.js b/src/components/select/select.spec.js index 751431e4e3d..d90c1d1f74d 100755 --- a/src/components/select/select.spec.js +++ b/src/components/select/select.spec.js @@ -91,15 +91,6 @@ describe('', function() { //expect($document[0].activeElement).toBe(select[0]); })); - it('should not convert numbers to strings', inject(function($compile, $rootScope) { - $rootScope.value = 1; - $compile('' + - '{{value}}' + - '')($rootScope); - $rootScope.$digest(); - expect($rootScope.value).toBe(1); - })); - describe('input container', function() { it('should set has-value class on container for non-ng-model input', inject(function($rootScope, $document) { var el = setupSelect('ng-model="$root.model"', [1, 2, 3]);