This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix (slider) - fixing slider default value in ng-repeat #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sonnylazuardi - have you signed a CLA so we can commit your PR? |
|
@ThomasBurleson how to sign a CLA? I have signed here https://cla.developers.google.com/clas |
|
@ThomasBurleson so, should I repeat this pull request after signing a CLA? |
|
No... once signed, we can start planning merges of your PRs (as appropriate) into our releases. Thx. |
|
@ThomasBurleson I have signed a CLA in Google Developers. Thank you. |
jeffbcross
pushed a commit
to jeffbcross/material
that referenced
this pull request
Oct 31, 2014
jeffbcross
pushed a commit
to jeffbcross/material
that referenced
this pull request
Oct 31, 2014
jeffbcross
pushed a commit
to jeffbcross/material
that referenced
this pull request
Nov 1, 2014
|
It still seems not working correctly in my case. https://embed.plnkr.co/FCizUTQnOTzsklhxSIry/ click SSD 1 -> SSD 10 direction set min and value correctly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-slider does not work within ng-repeat.
when i have used md-slider without ng-repeat the slider sets on its proper position and aria-valuenow is also set with its proper value, but when i have used md-slider within ng-repeat the aria-valuenow="NaN" and slider is not set with its proper position.
Plunker demo of problem - http://plnkr.co/edit/PslB2p?p=preview
With this pull request the default value of md-slider in ng-repeat will be correct.