This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): input error messages visible on form submit #6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jelbourn - thoughts? |
|
Yes, I think this should be the behavior. @EladBezalel This change needs a unit test. |
ThomasBurleson
added
needs: tests
and removed
needs: review
Added check for parent form `$submitted` attribute. Notice that `novalidate` attribute should be applied on parent form in order to make it work (Browser preventing submit when not specified) fixes #5752
EladBezalel
force-pushed
the
fix/input-error-messages-on-submit
branch
from
6ce708e
to
b929ad3
Compare
EladBezalel
added
needs: review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for parent form
$submittedattribute.Notice that
novalidateattribute should be applied on parent form in order to make it work (Browser preventing submit when not specified)fixes #5752