This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): check if parent form is undefined before checking if it's… #6809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @epelc. |
|
I had the same issue and had to remove the element from the dialog template. I guess now after this fix I can put the form tag back in :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… submitted
This fixes an issue I had with requiring inputs in form dialogs causing errors when you close the dialog. It should also fix the same issue in other situations as this is a fix for
md-input-container. It was just triggered with a dialog in my case.Fixes #6807