fix(datepicker): ensure the element always blends in with it's parent #7603
Conversation
topherfangio
added
needs: work
and removed
needs: review
|
I am not sure this is ready quite yet. If I manually set the background of my container to something like pink, there is still some part of the datepicker that is set to an incorrect color.
|
|
I'm not quite sure that we'd be able to accommodate for all of these cases though (e.g. a grandparent having a background etc.). The alternative could be to set it as transparent and have it inherit only when it's open? |
|
I think transparent is okay, but I currently don't understand why we're even setting the background for input elements at all. Is there ever a case in the spec where it doesn't have the same background as the parent container? |
|
I don't think so. I'll make it transparent and try out a few more scenarios just in case. |
crisbeto
force-pushed
the
fix/datepicker-background
branch
from
c1ce145
to
bd2fb5c
Compare
|
I've updated it @topherfangio. Now it's transparent when closed and when it's open, it uses the body background. I also managed to fix an issue where the datepicker would push it's surrounding content when it gets opened. |
* Makes the datepicker component transparent so it always blends in with it's parent. * Prevents the content around a datepicker from jumping when it gets opened. Closes angular#7502.
crisbeto
force-pushed
the
fix/datepicker-background
branch
from
07d5aa9
to
e58972a
Compare
crisbeto
added
needs: review
|
LGTM 👍 |
topherfangio
added
pr: merge ready
* Makes the datepicker component transparent so it always blends in with it's parent. * Prevents the content around a datepicker from jumping when it gets opened. Closes angular#7502. Closes angular#7603
fix(datepicker): ensure the element always blends in with it's parent
Closes #7502.