This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): don't apply a background if the autocomplete has a floating label #7848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… floating label The grey background should only be applied if the autocomplete doesn't have a floating label. Closes angular#7841.
|
@crisbeto - attribute selectors cause perf issues in IE; at least the Layout selectors did.
|
|
@ThomasBurleson There isn't any noticeable difference, but these things tend to stack up over time. I went with the attribute selector, because that's what was being used to style the floating label mode in the first place. I can switch it over to a class selector but that might be considered a breaking change? |
ThomasBurleson
added
pr: merge ready
ilovett
pushed a commit
to ilovett/material
that referenced
this pull request
Apr 22, 2016
… floating label The grey background should only be applied if the autocomplete doesn't have a floating label. Closes angular#7841. Closes angular#7848
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grey background should only be applied if the autocomplete doesn't have a floating label.
Closes #7841.