Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix css #44

Closed
wants to merge 1 commit into from
Closed

fix css #44

wants to merge 1 commit into from

Conversation

connectnew
Copy link

@connectnew connectnew commented Feb 18, 2020

First line in css file must empty or use for comment, because if it’s not, then when you use lazy loading and the webpack it breaks the styles.

webpackContext.id = "./node_modules/moment/locale sync recursive ^\\.\\/.*$";.vld-overlay {
  bottom: 0;
  left: 0;
  position: absolute;
  right: 0;
  top: 0;
  -webkit-box-align: center;
          align-items: center;
  display: none;
  -webkit-box-pack: center;
          justify-content: center;
  overflow: hidden;
  z-index: 1
}

@ankurk91
Copy link
Owner

@connectnew
Hi, i could not understand this, how can i re-produce this issue?

Can you show me an example of other similar package which has empty line in css?

@ankurk91
Copy link
Owner

@connectnew
what about having a banner

https://webpack.js.org/plugins/banner-plugin/

ankurk91 added a commit that referenced this pull request Feb 29, 2020
@ankurk91
Copy link
Owner

@connectnew
I have added a banner in output css file, it should be fixed in next release

@ankurk91 ankurk91 closed this Feb 29, 2020
@connectnew
Copy link
Author

connectnew commented Feb 29, 2020 via email

ankurk91 added a commit that referenced this pull request Mar 7, 2020
This reverts commit d6596f7.

This seems to be creating issue in nuxt js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants