From 81f25ca2cc3b5f6310a2a3d0e6df82366731ee46 Mon Sep 17 00:00:00 2001 From: Sebb Date: Tue, 30 Jul 2024 00:08:35 +0100 Subject: [PATCH] Use JUNit assertions not assert in tests --- .../legacy/analysis/integration/SimpsonIntegratorTest.java | 2 +- .../stat/regression/GLSMultipleLinearRegressionTest.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/integration/SimpsonIntegratorTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/integration/SimpsonIntegratorTest.java index 1788a5255f..e1adb46986 100644 --- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/integration/SimpsonIntegratorTest.java +++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/analysis/integration/SimpsonIntegratorTest.java @@ -200,7 +200,7 @@ private static double compositeSimpsonsRule(UnivariateFunction f, double a, // sum ~ h/3 * [ f(x0) + 4f(x1) + 2f(x2) + 4f(x3) + 2f(x4) ... + 4f(xn-1) + f(xn) ] // h = (b-a)/n // f(xi) = f(a + i*h) - assert n > 0 && (n & 1) == 0 : "n must be strictly positive and even"; + Assert.assertTrue( "n must be strictly positive and even, actual: " +n, n > 0 && (n & 1) == 0); final double h = (b - a) / n; double sum4 = 0; double sum2 = 0; diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/regression/GLSMultipleLinearRegressionTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/regression/GLSMultipleLinearRegressionTest.java index 722c3ac38d..a9f23c3433 100644 --- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/regression/GLSMultipleLinearRegressionTest.java +++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/stat/regression/GLSMultipleLinearRegressionTest.java @@ -293,7 +293,7 @@ public void testGLSEfficiency() { } // Verify that GLS is on average more efficient, lower variance - assert olsBetaStats.getMean() > 1.5 * glsBetaStats.getMean(); - assert olsBetaStats.getStandardDeviation() > glsBetaStats.getStandardDeviation(); + Assert.assertTrue(olsBetaStats.getMean() > 1.5 * glsBetaStats.getMean()); + Assert.assertTrue(olsBetaStats.getStandardDeviation() > glsBetaStats.getStandardDeviation()); } }