Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move VERSION file to src folder #1148

Closed
1 of 2 tasks
tisonkun opened this issue Dec 1, 2022 · 2 comments · Fixed by #1149
Closed
1 of 2 tasks

Move VERSION file to src folder #1148

tisonkun opened this issue Dec 1, 2022 · 2 comments · Fixed by #1149
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@tisonkun
Copy link
Member

tisonkun commented Dec 1, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

Move VERSION file to src folder, so that we have a tidy root layout.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@tisonkun tisonkun added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers labels Dec 1, 2022
@tisonkun
Copy link
Member Author

tisonkun commented Dec 1, 2022

You should correspondingly update the build logic to fulfill VERSION information, including those in x.py and CMakeList.txt.

@PragmaTwice
Copy link
Member

Actually I have some doubt about this proposal. In my view, the VERSION file is not a source file, which seems not proper to be placed into the src directory.

We can see the CI failed when someone try to move this file to src in #1149, whose reason is quite funny: there is a header named version in the C++ standard, and the move cause compiler to find wrong header and fail to compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants