From 3230415e22eaa2fdf96d6f5d29f664126e97ef6f Mon Sep 17 00:00:00 2001 From: "Hugh A. Miles II" Date: Thu, 17 Mar 2022 09:19:11 -0700 Subject: [PATCH] remove config (#19146) --- .../CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx | 5 ++++- superset/config.py | 4 ---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx index 7226efdcb4b37..96a0bfef07cc2 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/SqlAlchemyForm.tsx @@ -45,7 +45,10 @@ const SqlAlchemyTab = ({ fallbackDocsUrl = SupersetText.DB_MODAL_SQLALCHEMY_FORM?.SQLALCHEMY_DOCS_URL; fallbackDisplayText = - SupersetText.DB_MODAL_SQLALCHEMY_FORM?.SQLALCHEMY_DOCS_URL; + SupersetText.DB_MODAL_SQLALCHEMY_FORM?.SQLALCHEMY_DISPLAY_TEXT; + } else { + fallbackDocsUrl = 'https://docs.sqlalchemy.org/en/13/core/engines.html'; + fallbackDisplayText = 'SQLAlchemy docs'; } return ( <> diff --git a/superset/config.py b/superset/config.py index 26ce25228a19b..f2ed52206b93a 100644 --- a/superset/config.py +++ b/superset/config.py @@ -1343,10 +1343,6 @@ def SQL_QUERY_MUTATOR( # pylint: disable=invalid-name,unused-argument # Do not show user info or profile in the menu MENU_HIDE_USER_INFO = False -# SQLalchemy link doc reference -SQLALCHEMY_DOCS_URL = "https://docs.sqlalchemy.org/en/13/core/engines.html" -SQLALCHEMY_DISPLAY_TEXT = "SQLAlchemy docs" - # Set to False to only allow viewing own recent activity ENABLE_BROAD_ACTIVITY_ACCESS = True