From 52f099be720663caf535abefb8e539b5c58dc731 Mon Sep 17 00:00:00 2001
From: Antonio Rivero <antonioriverocode@gmail.com>
Date: Tue, 12 Jul 2022 16:38:05 -0300
Subject: [PATCH] Save Dataset Modal:

- Stop clearing the selected dataset after overwritting so users can overwrite as many times as they see fit
- There's a new AsyncSelect we should use now
---
 .../src/SqlLab/components/SaveDatasetModal/index.tsx       | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
index 4fbfe11adb607..0fa28095cc4f2 100644
--- a/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
+++ b/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
@@ -19,7 +19,7 @@
 
 import React, { FunctionComponent, useCallback, useState } from 'react';
 import { Radio } from 'src/components/Radio';
-import { RadioChangeEvent, Select } from 'src/components';
+import { RadioChangeEvent, AsyncSelect } from 'src/components';
 import { Input } from 'src/components/Input';
 import StyledModal from 'src/components/Modal';
 import Button from 'src/components/Button';
@@ -158,7 +158,7 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
             is_dttm: d.is_dttm,
           }),
         ),
-        datasetToOverwrite.owners.map((o: DatasetOwner) => o.id),
+        datasetToOverwrite.owners?.map((o: DatasetOwner) => o.id),
         true,
       ),
       postFormData(datasetToOverwrite.datasetid, 'table', {
@@ -178,7 +178,6 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
     window.open(url, '_blank', 'noreferrer');
 
     setShouldOverwriteDataset(false);
-    setDatasetToOverwrite({});
     setDatasetName(getDefaultDatasetName());
   };
 
@@ -359,7 +358,7 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
                   {t('Overwrite existing')}
                 </Radio>
                 <div className="sdm-autocomplete">
-                  <Select
+                  <AsyncSelect
                     allowClear
                     showSearch
                     placeholder={t('Select or type dataset name')}