Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] Chart embed code modal glitch #12445

Closed
1 task done
adam-stasiak opened this issue Jan 12, 2021 · 4 comments
Closed
1 task done

[explore] Chart embed code modal glitch #12445

adam-stasiak opened this issue Jan 12, 2021 · 4 comments
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:viz:explore:others Deprecated label - Use explore instead inactive Inactive for >= 30 days

Comments

@adam-stasiak
Copy link
Contributor

When I change size of code block then I can make this bigger than modal

Expected results

Modal should react to code size change.

Actual results

Code is outside the modal

Screenshots

Nagranie.z.ekranu.2021-01-12.o.14.40.56.mov

How to reproduce the bug

  1. Go to chart
  2. Click on embed code
  3. adjust size
  4. See error

Environment

commit 90915db
docker

  • superset version: superset version
  • python version: python --version
  • node.js version: node -v

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • [x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@adam-stasiak adam-stasiak added the #bug Bug report label Jan 12, 2021
@adam-stasiak adam-stasiak changed the title Chart embed code modal glitch [explore] Chart embed code modal glitch Jan 12, 2021
@junlincc junlincc added #bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:viz:explore:others Deprecated label - Use explore instead assigned:polidea and removed #bug Bug report Polidea labels Jan 12, 2021
@junlincc
Copy link
Member

@kgabryje let's hop on this one while i try to repro the other two bugs for ya~

@jinghua-qa
Copy link
Member

Still able to reproduce this issue

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

rusackas commented Feb 1, 2023

Looks like the PR that closed this wasn't linked properly. Closing!

@rusackas rusackas closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:viz:explore:others Deprecated label - Use explore instead inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

4 participants