Advanced Analytics time comparison is feature is not working

[stephanclaus]

A clear and concise description of what the bug is.

How to reproduce the bug

1. Create a new chart with Line or Smooth Line
2. Add a date column into the time column and select the same column for the x axis
3. Use the Advanced Analytics Section to create a lagging Metric with Time Shift (e.g. 1 year) and selection Actual Values
4. Click Update Chart
5. see error: Unexpected error Error: A time column must be specified when using a Time Comparison.

Expected results

The chart will be rendered as expected with a YoY comparison

Actual results

An error is thrown: Unexpected error Error: A time column must be specified when using a Time Comparison.

Screenshots

Environment

(please complete the following information):

• browser type and version: chrome Version 105.0.5195.102
• superset version: 2.0.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• [] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Used to work before in superset 1.5.1. When I remove the configuration in the Advanced Analytics Section, the chart will render just fine. I assume Superset is too restrictive when a date column is added but the Advanced Analytics really expect a time column.

[zhaoyongjie]

Hi @stephanclaus, what database do you use? I have fixed an issue at PR recently for the SQLite.

[stephanclaus]

Hi @zhaoyongjie, we are using Snowflake.

[zhaoyongjie]

@stephanclaus Could you reproduce this issue on the other database as well?

[stephanclaus]

@zhaoyongjie I just tried it again with a PostGres database and there the feature works as expected.

[mattitoo]

Can confirm this is not working on Snowflake

[zhaoyongjie]

@stephanclaus I can't reproduce this issue on the latest master and 2.1.0RC2. I believe this PR has fixed the issue.

cc: @mattitoo