From 3541e308cd184df2b7c51fdc5b9c6fdfedab7ad0 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 10 Apr 2022 17:51:02 -0400 Subject: [PATCH 01/26] spelling: adding Signed-off-by: Josh Soref --- docs/docs/installation/alerts-reports.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/installation/alerts-reports.mdx b/docs/docs/installation/alerts-reports.mdx index 8ab37cc90529a..a7491ad03eda0 100644 --- a/docs/docs/installation/alerts-reports.mdx +++ b/docs/docs/installation/alerts-reports.mdx @@ -387,7 +387,7 @@ THUMBNAIL_SELENIUM_USER = 'username_with_permission_to_access_dashboards' ### Schedule Reports -You can optionally allow your users to schedule queries directly in SQL Lab. This is done by addding +You can optionally allow your users to schedule queries directly in SQL Lab. This is done by adding extra metadata to saved queries, which are then picked up by an external scheduled (like [Apache Airflow](https://airflow.apache.org/)). From ffab6a00fc434762854fdf0003ead685341fbfd2 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 10 Apr 2022 17:51:05 -0400 Subject: [PATCH 02/26] spelling: aggregate Signed-off-by: Josh Soref --- .../creating-your-first-dashboard.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx b/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx index 39400a1c29031..e3fd6ddb42936 100644 --- a/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx +++ b/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx @@ -94,7 +94,7 @@ The Superset semantic layer can store 2 types of computed data: 1. Virtual metrics: you can write SQL queries that aggregate values from multiple column (e.g. `SUM(recovered) / SUM(confirmed)`) and make them available as columns for (e.g. `recovery_rate`) visualization in Explore. -Agggregate functions are allowed and encouraged for metrics. +Aggregate functions are allowed and encouraged for metrics. From d445c17f1fe77dfce0df69b186b5ef24bb7e0ced Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 10 Apr 2022 17:51:40 -0400 Subject: [PATCH 03/26] spelling: avoid Signed-off-by: Josh Soref --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 865d4b62d6b44..9f4f4f45b6343 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -661,7 +661,7 @@ We use [Pylint](https://pylint.org/) for linting which can be invoked via: tox -e pylint ``` -In terms of best practices please advoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled. +In terms of best practices please avoid blanket disablement of Pylint messages globally (via `.pylintrc`) or top-level within the file header, albeit there being a few exceptions. Disablement should occur inline as it prevents masking issues and provides context as to why said message is disabled. Additionally, the Python code is auto-formatted using [Black](https://github.com/python/black) which is configured as a pre-commit hook. There are also numerous [editor integrations](https://black.readthedocs.io/en/stable/integrations/editors.html) From 2f65927bbddcd787730a03c6b4dfef9138b2b37f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 10 Apr 2022 17:51:49 -0400 Subject: [PATCH 04/26] spelling: blacklist Signed-off-by: Josh Soref --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index 2915976bcd66a..783146e13c825 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -221,7 +221,7 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf - [10324](https://github.com/apache/superset/pull/10324): Facebook Prophet has been introduced as an optional dependency to add support for timeseries forecasting in the chart data API. To enable this feature, install Superset with the optional dependency `prophet` or directly `pip install fbprophet`. -- [10320](https://github.com/apache/superset/pull/10320): References to blacklst/whitelist language have been replaced with more appropriate alternatives. All configs refencing containing `WHITE`/`BLACK` have been replaced with `ALLOW`/`DENY`. Affected config variables that need to be updated: `TIME_GRAIN_BLACKLIST`, `VIZ_TYPE_BLACKLIST`, `DRUID_DATA_SOURCE_BLACKLIST`. +- [10320](https://github.com/apache/superset/pull/10320): References to blacklist/whitelist language have been replaced with more appropriate alternatives. All configs refencing containing `WHITE`/`BLACK` have been replaced with `ALLOW`/`DENY`. Affected config variables that need to be updated: `TIME_GRAIN_BLACKLIST`, `VIZ_TYPE_BLACKLIST`, `DRUID_DATA_SOURCE_BLACKLIST`. ## 0.37.1 From 3d89b2aa51f2bbf349c05502ad62e1491f989239 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Sun, 10 Apr 2022 17:52:03 -0400 Subject: [PATCH 05/26] spelling: cached Signed-off-by: Josh Soref --- UPDATING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UPDATING.md b/UPDATING.md index 783146e13c825..6e6d36a00a6bf 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -68,8 +68,8 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf ### Other - [17589](https://github.com/apache/superset/pull/17589): It is now possible to limit access to users' recent activity data by setting the `ENABLE_BROAD_ACTIVITY_ACCESS` config flag to false, or customizing the `raise_for_user_activity_access` method in the security manager. -- [17536](https://github.com/apache/superset/pull/17536): introduced a key-value endpoint to store dashboard filter state. This endpoint is backed by Flask-Caching and the default configuration assumes that the values will be stored in the file system. If you are already using another cache backend like Redis or Memchached, you'll probably want to change this setting in `superset_config.py`. The key is `FILTER_STATE_CACHE_CONFIG` and the available settings can be found in Flask-Caching [docs](https://flask-caching.readthedocs.io/en/latest/). -- [17882](https://github.com/apache/superset/pull/17882): introduced a key-value endpoint to store Explore form data. This endpoint is backed by Flask-Caching and the default configuration assumes that the values will be stored in the file system. If you are already using another cache backend like Redis or Memchached, you'll probably want to change this setting in `superset_config.py`. The key is `EXPLORE_FORM_DATA_CACHE_CONFIG` and the available settings can be found in Flask-Caching [docs](https://flask-caching.readthedocs.io/en/latest/). +- [17536](https://github.com/apache/superset/pull/17536): introduced a key-value endpoint to store dashboard filter state. This endpoint is backed by Flask-Caching and the default configuration assumes that the values will be stored in the file system. If you are already using another cache backend like Redis or Memcached, you'll probably want to change this setting in `superset_config.py`. The key is `FILTER_STATE_CACHE_CONFIG` and the available settings can be found in Flask-Caching [docs](https://flask-caching.readthedocs.io/en/latest/). +- [17882](https://github.com/apache/superset/pull/17882): introduced a key-value endpoint to store Explore form data. This endpoint is backed by Flask-Caching and the default configuration assumes that the values will be stored in the file system. If you are already using another cache backend like Redis or Memcached, you'll probably want to change this setting in `superset_config.py`. The key is `EXPLORE_FORM_DATA_CACHE_CONFIG` and the available settings can be found in Flask-Caching [docs](https://flask-caching.readthedocs.io/en/latest/). ## 1.4.1 From f251b43d22bba7620c2a43d17d2f32919c0924cf Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:36:55 -0400 Subject: [PATCH 06/26] spelling: discontinue Signed-off-by: Josh Soref --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index 6e6d36a00a6bf..0a4b7247856c4 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -179,7 +179,7 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf - [11575](https://github.com/apache/superset/pull/11575) The Row Level Security (RLS) config flag has been moved to a feature flag. To migrate, add `ROW_LEVEL_SECURITY: True` to the `FEATURE_FLAGS` dict in `superset_config.py`. -- [11259](https://github.com/apache/superset/pull/11259): config flag ENABLE_REACT_CRUD_VIEWS has been set to `True` by default, set to `False` if you prefer to the vintage look and feel. However, we may discontine support on the vintage list view in the future. +- [11259](https://github.com/apache/superset/pull/11259): config flag ENABLE_REACT_CRUD_VIEWS has been set to `True` by default, set to `False` if you prefer to the vintage look and feel. However, we may discontinue support on the vintage list view in the future. - [11244](https://github.com/apache/superset/pull/11244): The `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` feature flag has been removed after being set to True for multiple months. From 2def6d210a08c508ce869e26b28a2072fff0731c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:36:57 -0400 Subject: [PATCH 07/26] spelling: exhaustive Signed-off-by: Josh Soref --- docs/docs/miscellaneous/chart-params.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/miscellaneous/chart-params.mdx b/docs/docs/miscellaneous/chart-params.mdx index 0bd94db22694b..e7bef0e4a4830 100644 --- a/docs/docs/miscellaneous/chart-params.mdx +++ b/docs/docs/miscellaneous/chart-params.mdx @@ -9,7 +9,7 @@ version: 1 Chart parameters are stored as a JSON encoded string the `slices.params` column and are often referenced throughout the code as form-data. Currently the form-data is neither versioned nor typed as thus is somewhat free-formed. Note in the future there may be merit in using something like [JSON Schema](https://json-schema.org/) to both annotate and validate the JSON object in addition to using a Mypy `TypedDict` (introduced in Python 3.8) for typing the form-data in the backend. This section serves as a potential primer for that work. -The following tables provide a non-exhausive list of the various fields which can be present in the JSON object grouped by the Explorer pane sections. These values were obtained by extracting the distinct fields from a legacy deployment consisting of tens of thousands of charts and thus some fields may be missing whilst others may be deprecated. +The following tables provide a non-exhaustive list of the various fields which can be present in the JSON object grouped by the Explorer pane sections. These values were obtained by extracting the distinct fields from a legacy deployment consisting of tens of thousands of charts and thus some fields may be missing whilst others may be deprecated. Note not all fields are correctly categorized. The fields vary based on visualization type and may appear in different sections depending on the type. Verified deprecated columns may indicate a missing migration and/or prior migrations which were unsuccessful and thus future work may be required to clean up the form-data. From f1b8d691ae29242d8ac718fe84b89dbcb57cc3b3 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:36:59 -0400 Subject: [PATCH 08/26] spelling: from Signed-off-by: Josh Soref --- .../packages/superset-ui-core/src/number-format/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/packages/superset-ui-core/src/number-format/README.md b/superset-frontend/packages/superset-ui-core/src/number-format/README.md index c4663c0149c3b..e3e5099243b52 100644 --- a/superset-frontend/packages/superset-ui-core/src/number-format/README.md +++ b/superset-frontend/packages/superset-ui-core/src/number-format/README.md @@ -68,7 +68,7 @@ There is also a formatter based on [pretty-ms](https://www.npmjs.com/package/pre used to format time durations: ```js -import { createDurationFormatter, formatNumber, getNumberFormatterRegistry } from from '@superset-ui-number-format'; +import { createDurationFormatter, formatNumber, getNumberFormatterRegistry } from '@superset-ui-number-format'; getNumberFormatterRegistry().registerValue('my_duration_format', createDurationFormatter({ colonNotation: true }); console.log(formatNumber('my_duration_format', 95500)) From 2ca00768a1abb15004b1141d4fa1fd8b6dbafc3e Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:36:59 -0400 Subject: [PATCH 09/26] spelling: github Signed-off-by: Josh Soref --- CODE_OF_CONDUCT.md | 2 +- CONTRIBUTING.md | 4 ++-- RELEASING/README.md | 4 ++-- RELEASING/changelog.py | 2 +- docs/docs/contributing/contributing-page.mdx | 4 ++-- docs/docs/contributing/pull-request-guidelines.mdx | 2 +- docs/docs/creating-charts-dashboards/exploring-data.mdx | 2 +- docs/docs/databases/drill.mdx | 2 +- docs/docs/installation/configuring-superset.mdx | 2 +- .../installation/installing-superset-using-docker-compose.mdx | 2 +- docs/docs/intro.mdx | 2 +- 11 files changed, 14 insertions(+), 14 deletions(-) diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index e49cf0a32cc06..bee3a24a1e781 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -119,7 +119,7 @@ If you decide to join the [Community Slack](https://join.slack.com/t/apache-supe **3. Ask thoughtful questions.** -- We’re all here to help each other out. The best way to get help is by investing effort into your questions. First check and see if your question is answered in [the Superset documentation](https://superset.apache.org/faq.html) or on [Stack Overflow](https://stackoverflow.com/search?q=apache+superset). You can also check [Github issues](https://github.com/apache/superset/issues) to see if your question or feature request has been submitted before. Then, use Slack search to see if your question has already been asked and answered in the past. If you still feel the need to ask a question, make sure you include: +- We’re all here to help each other out. The best way to get help is by investing effort into your questions. First check and see if your question is answered in [the Superset documentation](https://superset.apache.org/faq.html) or on [Stack Overflow](https://stackoverflow.com/search?q=apache+superset). You can also check [GitHub issues](https://github.com/apache/superset/issues) to see if your question or feature request has been submitted before. Then, use Slack search to see if your question has already been asked and answered in the past. If you still feel the need to ask a question, make sure you include: - The steps you’ve already taken - Relevant details presented cleanly (text stacktraces, formatted markdown, or screenshots. Please don’t paste large blocks of code unformatted or post photos of your screen from your phone) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9f4f4f45b6343..bec0760f87fdb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -116,7 +116,7 @@ Here's a list of repositories that contain Superset-related packages: the [superset-frontend](https://github.com/apache/superset/tree/master/superset-frontend) folder. - [github.com/apache-superset](https://github.com/apache-superset) is the - Github organization under which we manage Superset-related + GitHub organization under which we manage Superset-related small tools, forks and Superset-related experimental ideas. ## Types of Contributions @@ -209,7 +209,7 @@ Finally, never submit a PR that will put master branch in broken state. If the P - `chore` (updating tasks etc; no application logic change) - `perf` (performance-related change) - `build` (build tooling, Docker configuration change) - - `ci` (test runner, Github Actions workflow changes) + - `ci` (test runner, GitHub Actions workflow changes) - `other` (changes that don't correspond to the above -- should be rare!) - Examples: - `feat: export charts as ZIP files` diff --git a/RELEASING/README.md b/RELEASING/README.md index 32fb1aef34cab..10fc26d51eed5 100644 --- a/RELEASING/README.md +++ b/RELEASING/README.md @@ -315,9 +315,9 @@ Once it's all done, an [ANNOUNCE] thread announcing the release to the dev@ mail python send_email.py announce ``` -### Github Release +### GitHub Release -Finally, so the Github UI reflects the latest release, you should create a release from the +Finally, so the GitHub UI reflects the latest release, you should create a release from the tag corresponding with the new version. Go to https://github.com/apache/superset/tags, click the 3-dot icon and select `Create Release`, paste the content of the ANNOUNCE thread in the release notes, and publish the new release. diff --git a/RELEASING/changelog.py b/RELEASING/changelog.py index 8e329b5fe0f6c..5d4f346c8edfb 100644 --- a/RELEASING/changelog.py +++ b/RELEASING/changelog.py @@ -26,7 +26,7 @@ try: from github import BadCredentialsException, Github, PullRequest, Repository except ModuleNotFoundError: - print("PyGithub is a required package for this script") + print("PyGitHub is a required package for this script") exit(1) SUPERSET_REPO = "apache/superset" diff --git a/docs/docs/contributing/contributing-page.mdx b/docs/docs/contributing/contributing-page.mdx index f4f3cd6400fb6..6e205bf0bbf81 100644 --- a/docs/docs/contributing/contributing-page.mdx +++ b/docs/docs/contributing/contributing-page.mdx @@ -13,8 +13,8 @@ which can be joined by anyone): - [Mailing list](https://lists.apache.org/list.html?dev@superset.apache.org) - [Apache Superset Slack community](https://join.slack.com/t/apache-superset/shared_invite/zt-16jvzmoi8-sI7jKWp~xc2zYRe~NqiY9Q) -- [Github issues and PR's](https://github.com/apache/superset/issues) +- [GitHub issues and PR's](https://github.com/apache/superset/issues) More references: - [Comprehensive Tutorial for Contributing Code to Apache Superset](https://preset.io/blog/tutorial-contributing-code-to-apache-superset/) -- [CONTRIBUTING Guide on Github](https://github.com/apache/superset/blob/master/CONTRIBUTING.md) +- [CONTRIBUTING Guide on GitHub](https://github.com/apache/superset/blob/master/CONTRIBUTING.md) diff --git a/docs/docs/contributing/pull-request-guidelines.mdx b/docs/docs/contributing/pull-request-guidelines.mdx index f37efd785eb60..4e2f823a979ed 100644 --- a/docs/docs/contributing/pull-request-guidelines.mdx +++ b/docs/docs/contributing/pull-request-guidelines.mdx @@ -41,7 +41,7 @@ Finally, never submit a PR that will put master branch in broken state. If the P - `chore` (updating tasks etc; no application logic change) - `perf` (performance-related change) - `build` (build tooling, Docker configuration change) - - `ci` (test runner, Github Actions workflow changes) + - `ci` (test runner, GitHub Actions workflow changes) - `other` (changes that don't correspond to the above -- should be rare!) - Examples: - `feat: export charts as ZIP files` diff --git a/docs/docs/creating-charts-dashboards/exploring-data.mdx b/docs/docs/creating-charts-dashboards/exploring-data.mdx index 65f7cae737996..0386b2384203f 100644 --- a/docs/docs/creating-charts-dashboards/exploring-data.mdx +++ b/docs/docs/creating-charts-dashboards/exploring-data.mdx @@ -40,7 +40,7 @@ tick the checkbox for **Allow Data Upload**. End by clicking the **Save** button ### Loading CSV Data Download the CSV dataset to your computer from -[Github](https://raw.githubusercontent.com/apache-superset/examples-data/master/tutorial_flights.csv). +[GitHub](https://raw.githubusercontent.com/apache-superset/examples-data/master/tutorial_flights.csv). In the Superset menu, select **Data ‣ Upload a CSV**. diff --git a/docs/docs/databases/drill.mdx b/docs/docs/databases/drill.mdx index 303eb55cbf22e..9265b5132d43e 100644 --- a/docs/docs/databases/drill.mdx +++ b/docs/docs/databases/drill.mdx @@ -43,5 +43,5 @@ drill+jdbc://:@: We recommend reading the [Apache Drill documentation](https://drill.apache.org/docs/installing-the-driver-on-linux/) and read -the [Github README](https://github.com/JohnOmernik/sqlalchemy-drill#usage-with-odbc) to learn how to +the [GitHub README](https://github.com/JohnOmernik/sqlalchemy-drill#usage-with-odbc) to learn how to work with Drill through ODBC. diff --git a/docs/docs/installation/configuring-superset.mdx b/docs/docs/installation/configuring-superset.mdx index 86bddda180f30..1c81d0cf80245 100644 --- a/docs/docs/installation/configuring-superset.mdx +++ b/docs/docs/installation/configuring-superset.mdx @@ -114,7 +114,7 @@ RequestHeader set X-Forwarded-Proto "https" ### Custom OAuth2 Configuration -Beyond FAB supported providers (Github, Twitter, LinkedIn, Google, Azure, etc), its easy to connect +Beyond FAB supported providers (GitHub, Twitter, LinkedIn, Google, Azure, etc), its easy to connect Superset with other OAuth2 Authorization Server implementations that support “code” authorization. Make sure the pip package [`Authlib`](https://authlib.org/) is installed on the webserver. diff --git a/docs/docs/installation/installing-superset-using-docker-compose.mdx b/docs/docs/installation/installing-superset-using-docker-compose.mdx index 4d7056a165d8b..129983fbc4a78 100644 --- a/docs/docs/installation/installing-superset-using-docker-compose.mdx +++ b/docs/docs/installation/installing-superset-using-docker-compose.mdx @@ -38,7 +38,7 @@ of that VM. We recommend assigning at least 8GB of RAM to the virtual machine as provisioning a hard drive of at least 40GB, so that there will be enough space for both the OS and all of the required dependencies. Docker Desktop [recently added support for Windows Subsystem for Linux (WSL) 2](https://docs.docker.com/docker-for-windows/wsl/), which may be another option. -### 2. Clone Superset's Github repository +### 2. Clone Superset's GitHub repository [Clone Superset's repo](https://github.com/apache/superset) in your terminal with the following command: diff --git a/docs/docs/intro.mdx b/docs/docs/intro.mdx index c4d0a138446cb..eb8a2f0a61fb0 100644 --- a/docs/docs/intro.mdx +++ b/docs/docs/intro.mdx @@ -19,7 +19,7 @@ Here are a **few different ways you can get started with Superset**: using [Docker Compose](installation/installing-superset-using-docker-compose) - Download the [Docker image](https://hub.docker.com/r/apache/superset) from Dockerhub - Install the latest version of Superset - [from Github](https://github.com/apache/superset/tree/latest) + [from GitHub](https://github.com/apache/superset/tree/latest) Superset provides: From eaec6b234e24b613c76691689f97f3e4399e27ec Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:36:59 -0400 Subject: [PATCH 10/26] spelling: hybrid Signed-off-by: Josh Soref --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index 0a4b7247856c4..b3898fdafdb00 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -235,7 +235,7 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf - [10222](https://github.com/apache/superset/pull/10222): a change which changes how payloads are cached. Previous cached objects cannot be decoded and thus will be reloaded from source. -- [10130](https://github.com/apache/superset/pull/10130): a change which deprecates the `dbs.perm` column in favor of SQLAlchemy [hybird attributes](https://docs.sqlalchemy.org/en/13/orm/extensions/hybrid.html). +- [10130](https://github.com/apache/superset/pull/10130): a change which deprecates the `dbs.perm` column in favor of SQLAlchemy [hybrid attributes](https://docs.sqlalchemy.org/en/13/orm/extensions/hybrid.html). - [10034](https://github.com/apache/superset/pull/10034): a change which deprecates the public security manager `assert_datasource_permission`, `assert_query_context_permission`, `assert_viz_permission`, and `rejected_tables` methods with the `raise_for_access` method which also handles assertion logic for SQL tables. From a4646207b575ec71ba00eb41497c64a510c6e598 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:36:59 -0400 Subject: [PATCH 11/26] spelling: implicit Signed-off-by: Josh Soref --- .../creating-your-first-dashboard.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx b/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx index e3fd6ddb42936..ecabf896f8e43 100644 --- a/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx +++ b/docs/docs/creating-charts-dashboards/creating-your-first-dashboard.mdx @@ -182,7 +182,7 @@ Access to dashboards is managed via owners (users that have edit permissions to Non-owner users access can be managed two different ways: -1. Dataset permissions - if you add to the relevant role permissions to datasets it automatically grants implict access to all dashboards that uses those permitted datasets +1. Dataset permissions - if you add to the relevant role permissions to datasets it automatically grants implicit access to all dashboards that uses those permitted datasets 2. Dashboard roles - if you enable **DASHBOARD_RBAC** feature flag then you be able to manage which roles can access the dashboard - Having dashboard access implicitly grants read access to the associated datasets, therefore all charts will load their data even if feature flag is turned on and no roles assigned From c9fe9b38450fd97bd8afcd4de59a1208697f4886 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:36:59 -0400 Subject: [PATCH 12/26] spelling: interim Signed-off-by: Josh Soref --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index b3898fdafdb00..a71a9ccc60996 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -25,7 +25,7 @@ assists people when migrating to a new version. ## Next - [19046](https://github.com/apache/superset/pull/19046): Enables the drag and drop interface in Explore control panel by default. Flips `ENABLE_EXPLORE_DRAG_AND_DROP` and `ENABLE_DND_WITH_CLICK_UX` feature flags to `True`. -- [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interm logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted. +- [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interim logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted. - [19570](https://github.com/apache/superset/pull/19570): makes [sqloxide](https://pypi.org/project/sqloxide/) optional so the SIP-68 migration can be run on aarch64. If the migration is taking too long installing sqloxide manually should improve the performance. ### Breaking Changes From 7fdf778e5de6933f0cce3d8a1e7937776d9df6a8 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:00 -0400 Subject: [PATCH 13/26] spelling: introduced Signed-off-by: Josh Soref --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index a71a9ccc60996..4f0b18ece7206 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -328,7 +328,7 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf - We're deprecating the concept of "restricted metric", this feature was not fully working anyhow. - [8117](https://github.com/apache/superset/pull/8117): If you are - using `ENABLE_PROXY_FIX = True`, review the newly-introducted variable, + using `ENABLE_PROXY_FIX = True`, review the newly-introduced variable, `PROXY_FIX_CONFIG`, which changes the proxy behavior in accordance with [Werkzeug](https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/) From 6a1f0970d3a4c4a84c5e3cdb10f06ecfe3ec37a3 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:00 -0400 Subject: [PATCH 14/26] spelling: javascript Signed-off-by: Josh Soref --- RELEASING/README.md | 2 +- .../src/components/FilterableTable/FilterableTable.tsx | 2 +- superset/charts/post_processing.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/RELEASING/README.md b/RELEASING/README.md index 10fc26d51eed5..46913d55ecad8 100644 --- a/RELEASING/README.md +++ b/RELEASING/README.md @@ -300,7 +300,7 @@ with the changes on `CHANGELOG.md` and `UPDATING.md`. ### Publishing a Convenience Release to PyPI Using the final release tarball, unpack it and run `./pypi_push.sh`. -This script will build the Javascript bundle and echo the twine command +This script will build the JavaScript bundle and echo the twine command allowing you to publish to PyPI. You may need to ask a fellow committer to grant you access to it if you don't have access already. Make sure to create an account first if you don't have one, and reference your username diff --git a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx index c0b49f8619d33..0616c925fd991 100644 --- a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx +++ b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx @@ -312,7 +312,7 @@ export default class FilterableTable extends PureComponent< this.props.orderedColumnKeys.forEach((key, index) => { // we can't use Math.max(...colWidths.slice(...)) here since the number // of elements might be bigger than the number of allowed arguments in a - // Javascript function + // JavaScript function widthsByColumnKey[key] = colWidths .slice( diff --git a/superset/charts/post_processing.py b/superset/charts/post_processing.py index 7b21290396b37..715f465574906 100644 --- a/superset/charts/post_processing.py +++ b/superset/charts/post_processing.py @@ -18,7 +18,7 @@ Functions to reproduce the post-processing of data on text charts. Some text-based charts (pivot tables and t-test table) perform -post-processing of the data in Javascript. When sending the data +post-processing of the data in JavaScript. When sending the data to users in reports we want to show the same data they would see on Explore. From 985e545a159c77ab04f5819af083bd544af764e1 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:00 -0400 Subject: [PATCH 15/26] spelling: logstash Signed-off-by: Josh Soref --- docs/docs/databases/elasticsearch.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/databases/elasticsearch.mdx b/docs/docs/databases/elasticsearch.mdx index 519bc370edf93..70b7f8f685e2b 100644 --- a/docs/docs/databases/elasticsearch.mdx +++ b/docs/docs/databases/elasticsearch.mdx @@ -46,7 +46,7 @@ POST /_aliases } ``` -Then register your table with the alias name logstasg_all +Then register your table with the alias name logstash_all **Time zone** From 4b6cb31bd3ec139a1101a8f0dca663e2aef754a4 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:01 -0400 Subject: [PATCH 16/26] spelling: metadata Signed-off-by: Josh Soref --- RELEASING/release-notes-1-2/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASING/release-notes-1-2/README.md b/RELEASING/release-notes-1-2/README.md index 2ae0a728f34f9..4e8895cbfea5e 100644 --- a/RELEASING/release-notes-1-2/README.md +++ b/RELEASING/release-notes-1-2/README.md @@ -87,7 +87,7 @@ Expanding the API has been an ongoing effort, and 1.2 introduces several new API - [14461](https://github.com/apache/superset/pull/14461) feat(native-filters): Auto apply changes in FiltersConfigModal (#14461) (@simcha90) - [13507](https://github.com/apache/superset/pull/13507) feat(native-filters): Filter set tabs (#13507) (@simcha90) - [14313](https://github.com/apache/superset/pull/14313) feat(native-filters): Implement adhoc filters and time picker in Range and Select native filters (#14313) (@Kamil Gabryjelski) -- [14261](https://github.com/apache/superset/pull/14261) feat(native-filters): Show/Hide filter bar by metdata ff (#14261) (@simcha90) +- [14261](https://github.com/apache/superset/pull/14261) feat(native-filters): Show/Hide filter bar by metadata ff (#14261) (@simcha90) - [13506](https://github.com/apache/superset/pull/13506) feat(native-filters): Update filter bar buttons (#13506) (@simcha90) - [14374](https://github.com/apache/superset/pull/14374) feat(native-filters): Use datasets in dashboard as default options for native filters (#14374) (@Kamil Gabryjelski) - [14314](https://github.com/apache/superset/pull/14314) feat(native-filters): add option to create value in select filter (#14314) (@Ville Brofeldt) From a895449a950233931b143eb70bba30fdd77d232f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:03 -0400 Subject: [PATCH 17/26] spelling: password Signed-off-by: Josh Soref --- docs/docs/databases/drill.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/databases/drill.mdx b/docs/docs/databases/drill.mdx index 9265b5132d43e..9006c8f98cf24 100644 --- a/docs/docs/databases/drill.mdx +++ b/docs/docs/databases/drill.mdx @@ -36,7 +36,7 @@ Connecting to Drill through JDBC is more complicated and we recommend following The connection string looks like: ``` -drill+jdbc://:@: +drill+jdbc://:@: ``` ### ODBC From 7dfd6682b9406e20da91ae85396d08562f11cdf7 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:07 -0400 Subject: [PATCH 18/26] spelling: recommended Signed-off-by: Josh Soref --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bec0760f87fdb..738f018873433 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -488,7 +488,7 @@ To bring all dependencies up to date as per the restrictions defined in `setup.p $ pip-compile-multi ``` -This should be done periodically, but it is rcommended to do thorough manual testing of the application to ensure no breaking changes have been introduced that aren't caught by the unit and integration tests. +This should be done periodically, but it is recommended to do thorough manual testing of the application to ensure no breaking changes have been introduced that aren't caught by the unit and integration tests. #### Logging to the browser console From b1bbdd88f1296e487fb237a84a370cfe99b710e5 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:07 -0400 Subject: [PATCH 19/26] spelling: redshift Signed-off-by: Josh Soref --- docs/src/resources/data.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/resources/data.js b/docs/src/resources/data.js index 3c0cf718a4b16..b37548d5212c2 100644 --- a/docs/src/resources/data.js +++ b/docs/src/resources/data.js @@ -19,7 +19,7 @@ export const Databases = [ { - title: 'Amazon Redshfit', + title: 'Amazon Redshift', href: 'https://aws.amazon.com/redshift/', imgName: 'aws-redshift.png', }, From 8c9c726466f008b6931238763a360fa51098e2e2 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:07 -0400 Subject: [PATCH 20/26] spelling: refactored Signed-off-by: Josh Soref --- RELEASING/release-notes-0-38/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASING/release-notes-0-38/README.md b/RELEASING/release-notes-0-38/README.md index 483271fa25a8c..817f27d771966 100644 --- a/RELEASING/release-notes-0-38/README.md +++ b/RELEASING/release-notes-0-38/README.md @@ -167,7 +167,7 @@ Other features Alerts (send notification when a condition is met) ([Roadmap](https://github.com/apache-superset/superset-roadmap/issues/54)) - feat: add test email functionality to SQL-based email alerts (#[10476](https://github.com/apache/superset/pull/10476)) -- feat: refractored SQL-based alerting framework (#[10605](https://github.com/apache/superset/pull/10605)) +- feat: refactored SQL-based alerting framework (#[10605](https://github.com/apache/superset/pull/10605)) [SIP-34] Proposal to establish a new design direction, system, and process for Superset ([SIP](https://github.com/apache/superset/issues/8976)) From 57f722e266e6b14c53cc9b62fc9c9ca49d1daf68 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:08 -0400 Subject: [PATCH 21/26] spelling: referencing Signed-off-by: Josh Soref --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index 4f0b18ece7206..0fa1eda6c13e3 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -221,7 +221,7 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf - [10324](https://github.com/apache/superset/pull/10324): Facebook Prophet has been introduced as an optional dependency to add support for timeseries forecasting in the chart data API. To enable this feature, install Superset with the optional dependency `prophet` or directly `pip install fbprophet`. -- [10320](https://github.com/apache/superset/pull/10320): References to blacklist/whitelist language have been replaced with more appropriate alternatives. All configs refencing containing `WHITE`/`BLACK` have been replaced with `ALLOW`/`DENY`. Affected config variables that need to be updated: `TIME_GRAIN_BLACKLIST`, `VIZ_TYPE_BLACKLIST`, `DRUID_DATA_SOURCE_BLACKLIST`. +- [10320](https://github.com/apache/superset/pull/10320): References to blacklist/whitelist language have been replaced with more appropriate alternatives. All configs referencing containing `WHITE`/`BLACK` have been replaced with `ALLOW`/`DENY`. Affected config variables that need to be updated: `TIME_GRAIN_BLACKLIST`, `VIZ_TYPE_BLACKLIST`, `DRUID_DATA_SOURCE_BLACKLIST`. ## 0.37.1 From 2e93515283bc503185221fd469df6c98c434b127 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:09 -0400 Subject: [PATCH 22/26] spelling: sqlite Signed-off-by: Josh Soref --- docs/src/resources/data.js | 2 +- .../img/databases/{sqllite.jpg => sqlite.jpg} | Bin .../img/databases/{sqllite.png => sqlite.png} | Bin ...96e99fb176a0_add_import_mixing_to_saved_query.py | 2 +- .../b56500de1855_add_uuid_column_to_import_mixin.py | 2 +- .../c501b7c653a3_add_missing_uuid_column.py | 2 +- 6 files changed, 4 insertions(+), 4 deletions(-) rename docs/static/img/databases/{sqllite.jpg => sqlite.jpg} (100%) rename docs/static/img/databases/{sqllite.png => sqlite.png} (100%) diff --git a/docs/src/resources/data.js b/docs/src/resources/data.js index b37548d5212c2..08d0781f86965 100644 --- a/docs/src/resources/data.js +++ b/docs/src/resources/data.js @@ -106,7 +106,7 @@ export const Databases = [ { title: 'SQLite', href: 'https://www.sqlite.org/index.html', - imgName: 'sqllite.png', + imgName: 'sqlite.png', }, { title: 'Trino', diff --git a/docs/static/img/databases/sqllite.jpg b/docs/static/img/databases/sqlite.jpg similarity index 100% rename from docs/static/img/databases/sqllite.jpg rename to docs/static/img/databases/sqlite.jpg diff --git a/docs/static/img/databases/sqllite.png b/docs/static/img/databases/sqlite.png similarity index 100% rename from docs/static/img/databases/sqllite.png rename to docs/static/img/databases/sqlite.png diff --git a/superset/migrations/versions/96e99fb176a0_add_import_mixing_to_saved_query.py b/superset/migrations/versions/96e99fb176a0_add_import_mixing_to_saved_query.py index 57d22aa089aa2..6c64fb0ff8f41 100644 --- a/superset/migrations/versions/96e99fb176a0_add_import_mixing_to_saved_query.py +++ b/superset/migrations/versions/96e99fb176a0_add_import_mixing_to_saved_query.py @@ -80,7 +80,7 @@ def upgrade(): try: # Add uniqueness constraint with op.batch_alter_table("saved_query") as batch_op: - # Batch mode is required for sqllite + # Batch mode is required for sqlite batch_op.create_unique_constraint("uq_saved_query_uuid", ["uuid"]) except OperationalError: pass diff --git a/superset/migrations/versions/b56500de1855_add_uuid_column_to_import_mixin.py b/superset/migrations/versions/b56500de1855_add_uuid_column_to_import_mixin.py index 747ec9fb4f77f..fb62041b3ecb0 100644 --- a/superset/migrations/versions/b56500de1855_add_uuid_column_to_import_mixin.py +++ b/superset/migrations/versions/b56500de1855_add_uuid_column_to_import_mixin.py @@ -182,7 +182,7 @@ def upgrade(): # add uniqueness constraint with op.batch_alter_table(table_name) as batch_op: - # batch mode is required for sqllite + # batch mode is required for sqlite batch_op.create_unique_constraint(f"uq_{table_name}_uuid", ["uuid"]) # add UUID to Dashboard.position_json diff --git a/superset/migrations/versions/c501b7c653a3_add_missing_uuid_column.py b/superset/migrations/versions/c501b7c653a3_add_missing_uuid_column.py index 4cfbc104c01db..9d4a77781fe85 100644 --- a/superset/migrations/versions/c501b7c653a3_add_missing_uuid_column.py +++ b/superset/migrations/versions/c501b7c653a3_add_missing_uuid_column.py @@ -77,7 +77,7 @@ def upgrade(): # add uniqueness constraint with op.batch_alter_table(table_name) as batch_op: - # batch mode is required for sqllite + # batch mode is required for sqlite batch_op.create_unique_constraint(f"uq_{table_name}_uuid", ["uuid"]) # add UUID to Dashboard.position_json; this function is idempotent From 9be6cee8a65243d07fa5f9b7538ac36ce14fa619 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:10 -0400 Subject: [PATCH 23/26] spelling: the Signed-off-by: Josh Soref --- docs/docs/installation/configuring-superset.mdx | 2 +- docs/docs/installation/sql-templating.mdx | 6 +++--- superset/utils/pandas_postprocessing/pivot.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/docs/installation/configuring-superset.mdx b/docs/docs/installation/configuring-superset.mdx index 1c81d0cf80245..fc8a6339333fa 100644 --- a/docs/docs/installation/configuring-superset.mdx +++ b/docs/docs/installation/configuring-superset.mdx @@ -99,7 +99,7 @@ If you're not using Gunicorn, you may want to disable the use of `flask-compress If you are running superset behind a load balancer or reverse proxy (e.g. NGINX or ELB on AWS), you may need to utilize a healthcheck endpoint so that your load balancer knows if your superset instance is running. This is provided at `/health` which will return a 200 response containing “OK” -if the the webserver is running. +if the webserver is running. If the load balancer is inserting `X-Forwarded-For/X-Forwarded-Proto` headers, you should set `ENABLE_PROXY_FIX = True` in the superset config file (`superset_config.py`) to extract and use the diff --git a/docs/docs/installation/sql-templating.mdx b/docs/docs/installation/sql-templating.mdx index 2a80f0fbf65f6..8908d39f0280e 100644 --- a/docs/docs/installation/sql-templating.mdx +++ b/docs/docs/installation/sql-templating.mdx @@ -119,7 +119,7 @@ In this section, we'll walkthrough the pre-defined Jinja macros in Superset. The `{{ current_username() }}` macro returns the username of the currently logged in user. -If you have caching enabled in your Superset configuration, then by default the the `username` value will be used +If you have caching enabled in your Superset configuration, then by default the `username` value will be used by Superset when calculating the cache key. A cache key is a unique identifier that determines if there's a cache hit in the future and Superset can retrieve cached data. @@ -134,7 +134,7 @@ cache key by adding the following parameter to your Jinja code: The `{{ current_user_id() }}` macro returns the user_id of the currently logged in user. -If you have caching enabled in your Superset configuration, then by default the the `user_id` value will be used +If you have caching enabled in your Superset configuration, then by default the `user_id` value will be used by Superset when calculating the cache key. A cache key is a unique identifier that determines if there's a cache hit in the future and Superset can retrieve cached data. @@ -182,7 +182,7 @@ Here's a concrete example: **Explicitly Including Values in Cache Key** The `{{ cache_key_wrapper() }}` function explicitly instructs Superset to add a value to the -accumulated list of values used in the the calculation of the cache key. +accumulated list of values used in the calculation of the cache key. This function is only needed when you want to wrap your own custom function return values in the cache key. You can gain more context diff --git a/superset/utils/pandas_postprocessing/pivot.py b/superset/utils/pandas_postprocessing/pivot.py index 829329e71fc8b..89a187ce89c0b 100644 --- a/superset/utils/pandas_postprocessing/pivot.py +++ b/superset/utils/pandas_postprocessing/pivot.py @@ -56,7 +56,7 @@ def pivot( # pylint: disable=too-many-arguments,too-many-locals :param drop_missing_columns: Do not include columns whose entries are all missing :param combine_value_with_metric: Display metrics side by side within each column, as opposed to each column being displayed side by side for each metric. - :param aggregates: A mapping from aggregate column name to the the aggregate + :param aggregates: A mapping from aggregate column name to the aggregate config. :param marginal_distributions: Add totals for row/column. Default to False :param marginal_distribution_name: Name of row/column with marginal distribution. From 8e67eb760e475778f7e0dcc2c9b64d52104538d9 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:10 -0400 Subject: [PATCH 24/26] spelling: thumbnails Signed-off-by: Josh Soref --- docker-compose.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker-compose.yml b/docker-compose.yml index b7bf745ad6ff6..32ad70e0b8047 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -118,7 +118,7 @@ services: depends_on: *superset-depends-on user: *superset-user volumes: *superset-volumes - # Bump memory limit if processing selenium / thumbails on superset-worker + # Bump memory limit if processing selenium / thumbnails on superset-worker # mem_limit: 2038m # mem_reservation: 128M From 95a5128313ace8f3145f1ff9e726335787ab8005 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:10 -0400 Subject: [PATCH 25/26] spelling: undoes Signed-off-by: Josh Soref --- UPDATING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index 0fa1eda6c13e3..02cf649848d3a 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -192,7 +192,7 @@ flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in conf ### Potential Downtime -- [11920](https://github.com/apache/superset/pull/11920): Undos the DB migration from [11714](https://github.com/apache/superset/pull/11714) to prevent adding new columns to the logs table. Deploying a sha between these two PRs may result in locking your DB. +- [11920](https://github.com/apache/superset/pull/11920): Undoes the DB migration from [11714](https://github.com/apache/superset/pull/11714) to prevent adding new columns to the logs table. Deploying a sha between these two PRs may result in locking your DB. - [11714](https://github.com/apache/superset/pull/11714): Logs significantly more analytics events (roughly double?), and when From 9dbdd0020466291f7e7c4a485c9a7b61c339b20e Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Mon, 11 Apr 2022 21:37:11 -0400 Subject: [PATCH 26/26] spelling: very Signed-off-by: Josh Soref --- RELEASING/release-notes-1-4/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASING/release-notes-1-4/README.md b/RELEASING/release-notes-1-4/README.md index 9d3a7e99d32f8..267b122abaaf9 100644 --- a/RELEASING/release-notes-1-4/README.md +++ b/RELEASING/release-notes-1-4/README.md @@ -19,7 +19,7 @@ under the License. # Release Notes for Superset 1.4 -Superset 1.4 focuses heavily on continuing to polish the core Superset experience. This release has a very very long list of fixes from across the community. +Superset 1.4 focuses heavily on continuing to polish the core Superset experience. This release has a very long list of fixes from across the community. - [**User Experience**](#user-facing-features) - [**Database Experience**](#database-experience)