From fa3ad3061643a3cd06a211297a50499c9e77ef6a Mon Sep 17 00:00:00 2001 From: hughhhh Date: Thu, 1 Sep 2022 12:59:45 -0700 Subject: [PATCH 1/3] update test --- tests/unit_tests/explore/api_test.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 tests/unit_tests/explore/api_test.py diff --git a/tests/unit_tests/explore/api_test.py b/tests/unit_tests/explore/api_test.py new file mode 100644 index 0000000000000..df98cb1f912b5 --- /dev/null +++ b/tests/unit_tests/explore/api_test.py @@ -0,0 +1,13 @@ +from typing import Any + +import pytest + + +def test_explore_datasource_not_found(client: Any, full_api_access: None) -> None: + # validating the payload for a dataset that doesn't exist + # user should be expecting missing_datasource view + response = client.get( + "/api/v1/explore/?dataset_id=50000&dataset_type=table", + ) + response.json["result"]["dataset"]["name"] == "[Missing Dataset]" + assert response.status_code == 200 From fd3de01e3251d2036804e2c0e0689711a217f77c Mon Sep 17 00:00:00 2001 From: hughhhh Date: Thu, 1 Sep 2022 13:28:03 -0700 Subject: [PATCH 2/3] add test for not found from datasource dao --- tests/unit_tests/datasource/dao_tests.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/unit_tests/datasource/dao_tests.py b/tests/unit_tests/datasource/dao_tests.py index 8647f97f747c2..cb313b3dd7e17 100644 --- a/tests/unit_tests/datasource/dao_tests.py +++ b/tests/unit_tests/datasource/dao_tests.py @@ -202,3 +202,15 @@ def test_get_all_datasources(session_with_data: Session) -> None: result = SqlaTable.get_all_datasources(session=session_with_data) assert len(result) == 1 + + +def test_not_found_datasource(session_with_data: Session) -> None: + from superset.dao.exceptions import DatasourceNotFound + from superset.datasource.dao import DatasourceDAO + + with pytest.raises(DatasourceNotFound): + DatasourceDAO.get_datasource( + datasource_type="table", + datasource_id=500000, + session=session_with_data, + ) From 6f7f9fae76a5f06175976ab0398c95ede30c3c5c Mon Sep 17 00:00:00 2001 From: hughhhh Date: Thu, 1 Sep 2022 13:31:38 -0700 Subject: [PATCH 3/3] add license --- tests/unit_tests/explore/api_test.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/unit_tests/explore/api_test.py b/tests/unit_tests/explore/api_test.py index df98cb1f912b5..7f6d8ee2b240b 100644 --- a/tests/unit_tests/explore/api_test.py +++ b/tests/unit_tests/explore/api_test.py @@ -1,3 +1,20 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + from typing import Any import pytest