Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express v5 #7928

Open
joergbaier opened this issue Sep 13, 2024 · 3 comments
Open

express v5 #7928

joergbaier opened this issue Sep 13, 2024 · 3 comments

Comments

@joergbaier
Copy link

@apollo/server has express v4 as a dependency. After several years, express is moving forward with releasing v5 (currently published as next tag). Having support for v5 here would unblock and encourage people to upgrade.

https://www.npmjs.com/package/express?activeTab=versions
https://github.com/expressjs/express/releases/tag/v5.0.0

At this time, I have not checked for breaking changes in this repo, but wanted to open this issue to get things rolling. Any changes could be published under the next tag as well.

@joergbaier
Copy link
Author

Typing updates for @types/express & @types/express-serve-static-core
DefinitelyTyped/DefinitelyTyped#70563

@RobinTail
Copy link

Breaking changes are listed in the migration guide, which is not yet up to date. Besides the listed changes there is also Node.js min supported version: 18.
The primary feature is proper handling of asynchronous handlers.

@glasser
Copy link
Member

glasser commented Sep 16, 2024

I think it would be a good start if community members wanted to publish Express 5 integrations separately (perhaps under the @as-integrations npm org / apollo-server-integrations GitHub org)! While we could add a @apollo/server/express5 directory directly to Apollo Server, it might be challenging to do so in a way that uses different dependencies for two different parts of the same npm module, so getting this in core might be more likely a thing for the next major version of AS, which is not currently scheduled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants