Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS file editor GUI_FILE_EDIT #11668

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Apr 11, 2021

Description:

Let's edit autoexec.bat and all Berry files on the target
Optionally enabled with #define GUI_EDIT_FILE

Tested both on ESP8266 with 4MB linker file and ESP32 with default 64kB FFS
Tested only on root folder of FFS
Not tested yet with big files (no size control implemented)
Not tested with SDCARD and folders (testers welcomed as I don't have a board with SDCARD slot)

Note: I also changed the href to file download & delete to be relative instead of absolute with IP address. That's nicer when you open the Web GUI from a hostname instead of an IP address and also wouldn't work when accessing a device through a ssh tunnel (it's local IP address is not the one you are using to access it).

image

image

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@barbudor barbudor changed the title UFF file editor GUI_FILE_EDIT UFS file editor GUI_FILE_EDIT Apr 11, 2021
@arendst arendst merged commit d1adb55 into arendst:development Apr 11, 2021
@barbudor barbudor deleted the pr_ufs_edit branch April 18, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants