Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB driver properly support https URL #19582

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

barbudor
Copy link
Contributor

Description:

Related issue (if applicable): fixes #19526

Allows proper support of cloud based InfluxDB which use HTTPS URL
HTTPS is only supported on ESP32, don't even try with ESP8286 as it will not connect.

Exemple:

backlog ifxhost https://eu-central-1-1.aws.cloud2.influxdata.com; ifxport 443; ifxorg *******; ifxbucket tasmota; ifxtoken *****

It is mandatory to specify the port as 443 with a HTTPS URL because default InfluxDB port is 8086 and enforced by the driver init. I didn't want to break that which is the expected behavior for people using local InfluxDB.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • [-] The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.13
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@barbudor barbudor changed the title support https URL InfluxDB driver properly support https URL Sep 24, 2023
@arendst
Copy link
Owner

arendst commented Sep 24, 2023

I love small changes!!!

@arendst arendst merged commit 0d7c2de into arendst:development Sep 24, 2023
63 checks passed
dilyanpalauzov pushed a commit to dilyanpalauzov/Tasmota that referenced this pull request Oct 1, 2023
@barbudor barbudor deleted the influxdb_https branch November 29, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants