-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commands ADD, SUB, MULT, etc only use integers #3083
Comments
There is a dedicated (small code footprint) function for this. Don't remember the name but it's in support.ino. Once found look for code examples already in tasmota |
Great. Will look for it. Thanks! |
It's function |
So as to use decimal values in the If you think that this new search function could be useful for another routines, we can move it to support.ino Also, if you think that can be improved in any way, I'm willing to help. |
Thnx! I will do some clean-up and post the updated one tomorrow. |
I did make some tests with multi DS18B20 sensors and can confirm that decimal values for KNXTX_VALx work. |
Excelent! Thanks 👍 |
but could it be that you only send 1 digit after the dot with KNXTX_VALx? |
Hi @misc2000 KNXTX_VALx is sending 2 decimal digits. Can you try again? My console output (sending): My Home Assistant (receiving): |
@ascillato As you can see sensor1 is with 2 digits and sensor2 only rounded after the 1 digit. Here also a record of the values of this 2 KNX groups from the last hours:
Also the same 2nd Value only with 1 digit :-( |
Will investigate |
Hi, when looking at the teleperiod message, in the json message can be seen that the value is already there with just 1 decimal. This is being done by the DS18B20 driver. So for making it display 2 decimal digital, just go to the console and type the command |
works ! |
Yes, was different because the DS18B20 driver apply that Temperature resolution when putting the value in the teleperiod message, while the knx driver was taking the value before that. |
Describe the bug
A clear and concise description of what the bug is.
The following commands only support integers. When using values with decimals, those are truncated to integers:
ADDx
SUBx
MULTx
SCALEx
KNXTX_VALx
I'm informing this to be taken into account. I will work on this to try to support decimals. Any Help or suggestion is welcome.
Also, make sure these boxes are checked [x] before submitting your issue - Thank you!
status 0
:To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
That the values with decimals were not truncated to integers
Screenshots
If applicable, add screenshots to help explain your problem.
None
Additional context
Add any other context about the problem here.
None
(Please, remember to close the issue when the problem has been addressed)
The text was updated successfully, but these errors were encountered: