Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wraparound bug in backlog #9995

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Nov 27, 2020

Description:

Fix wraparound bug in backlog caused by assuming that millis time 0 would always be in the past.
After around 25 days of uptime, millis() passed 2^31 and the backlog stopped working.

Also rename backlog_delay to backlog_timer + fix a similar (but more harmless) assumption in wifiKeepAlive

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.7
  • The code change is tested and works on Tasmota core ESP32 V.1.0.4.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Copy link
Contributor

@effelle effelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ESP32. All fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants