Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable custom memory manager (Custom StlAllocator) #382

Open
1 of 2 tasks
OnlyOneMoreGeek opened this issue Feb 11, 2022 · 4 comments
Open
1 of 2 tasks

Disable custom memory manager (Custom StlAllocator) #382

OnlyOneMoreGeek opened this issue Feb 11, 2022 · 4 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@OnlyOneMoreGeek
Copy link

Confirm by changing [ ] to [x] below:

Known Issue

  • I'm using ATS data type endpoint: the endpoint should look like <prefix>-ats.iot.<region>.amazonaws.com

Platform/OS/Device
What are you running the sdk on?
Linux x86
Describe the question

When using the sdk, the Aws::Crt types that wrap stl containers use custom allocators by default. This disables the castings of the stl to the AWS::crt (e.g. std::string to Aws::Crt:String).

Is there any way to disable these custom allocators?

@OnlyOneMoreGeek OnlyOneMoreGeek added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Feb 11, 2022
@jmklix
Copy link
Member

jmklix commented Feb 12, 2022

I don't think that its possible to disable the custom memory manager for this sdk. Would using user defined conversion functions work for your use case?

@jmklix jmklix added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 2 days. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 12, 2022
@jmklix jmklix self-assigned this Feb 12, 2022
@github-actions
Copy link

Greetings! It looks like this issue hasn’t been active in longer than a week. We encourage you to check if this is still an issue in the latest release. Because it has been longer than a week since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or add an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 5 days unless further comments are made. label Feb 14, 2022
@OnlyOneMoreGeek
Copy link
Author

I don't think that its possible to disable the custom memory manager for this sdk. Would using user defined conversion functions work for your use case?

I think the library should provide user-defined conversions for Aws::Crt::String and Aws:_Crt::Vector to those in the STL. I think it is necessary for the library to allow avoiding unnecessary copies. The other alternative should be to completely disable the memory manager as is done in the aws C++ sdk Link

@github-actions github-actions bot removed closing-soon This issue will automatically close in 5 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 2 days. labels Feb 14, 2022
@jmklix
Copy link
Member

jmklix commented Feb 16, 2022

Thanks for your feedback. This is something that is not currently supported, but I will change this to a feature request. I don't have a timeline for when this might get added, but I encourage you to upvote the initial comment if you would like this added to this sdk.

@jmklix jmklix removed their assignment Feb 16, 2022
@jmklix jmklix added feature-request A feature should be added or improved. and removed guidance Question that needs advice or information. labels Feb 16, 2022
@jmklix jmklix added the p2 This is a standard priority issue label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants