Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenJDK Version #1065

Closed
rmartin16 opened this issue Jan 28, 2023 · 4 comments · Fixed by #1271
Closed

Bump OpenJDK Version #1065

rmartin16 opened this issue Jan 28, 2023 · 4 comments · Fixed by #1271
Labels
bug A crash or error in behavior.

Comments

@rmartin16
Copy link
Member

Describe the bug

The JDK version has been superseded; putting this out there to consider bumping it.

src/briefcase/integrations/java.py

        # As of April 10 2020, 8u242-b08 is the current AdoptOpenJDK
        # https://adoptopenjdk.net/releases.html
        self.release = "8u242"
        self.build = "b08"

Version jdk8u362-b09 is available.
Additionally, version 11 is also LTS.

There is also this banner at the website:
24th July 2021: AdoptOpenJDK is moving to the Eclipse Foundation and rebranding.
Our July 2021 and future releases will come from Adoptium.net

Steps to reproduce

briefcase run android will require the jdk.

Expected behavior

Not entirely sure....but it seems like we want to avoid the JDK getting too old.

Screenshots

No response

Environment

  • Operating System: pop os 22.04
  • Python version: 3.11
  • Software versions:
    • Briefcase: 0.3.12.dev359+gcf18ae8c.d20230128

Logs

No response

Additional context

No response

@rmartin16 rmartin16 added the bug A crash or error in behavior. label Jan 28, 2023
@mhsmith
Copy link
Member

mhsmith commented Jan 28, 2023

For discussion about Java 8 vs 11 vs 17, see #827.

@freakboy3742
Copy link
Member

Keeping this ticket open as a marker for the specific task of upgrading the Java version; #827 is then the co-dependent task of managing any gradle-plugin changes, and the upgrade path related to that.

@rmartin16
Copy link
Member Author

rmartin16 commented Feb 6, 2023

FYI. The GitHub runner sets JAVA_HOME; appears to be jdk 11. As with the Windows runner where I recently unset WIX, may need to consider unsetting JAVA_HOME in CI.

*************************************************************************
** WARNING: JAVA_HOME does not point to a Java 8 JDK                   **
*************************************************************************
    Android requires a Java 8 JDK, but the location pointed to by the
    JAVA_HOME environment variable:
    /usr/lib/jvm/temurin-11-jdk-amd64
    isn't a Java 8 JDK (it appears to be Java 11.0.[18](https://github.com/beeware/briefcase/actions/runs/4100113254/jobs/7070712081#step:17:19)).
    Briefcase will use its own JDK instance.
*************************************************************************
[java] The Java JDK was not found; downloading and installing...

@mhsmith
Copy link
Member

mhsmith commented Feb 26, 2023

Related: #1112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants