Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serde in the rust implementation #151

Open
extrawurst opened this issue Sep 2, 2021 · 4 comments
Open

Support serde in the rust implementation #151

extrawurst opened this issue Sep 2, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@extrawurst
Copy link

Is your feature request related to a problem? Please describe.
I would really like to switch from proto to bebop but one thing it misses is supporting serialization to and from json for debugging.

Describe the solution you'd like
It would be great if bebop would add support to generate and decode to and from json aswell

@extrawurst extrawurst added the enhancement New feature or request label Sep 2, 2021
@mattiekat
Copy link
Contributor

mattiekat commented Sep 2, 2021

I see a lot of the projects on your home page are in Rust. It would be pretty easy for me to add serde derive statements behind a feature flag which would allow using serde_json as well as the bebop serialization pathway.

@extrawurst
Copy link
Author

I see a lot of the projects on your home page are in Rust. It would be pretty easy for me to add serde derive statements behind a feature flag which would allow using serde_json as well as the bebop serialization pathway.

a feature flag would be perfect!

@mattiekat mattiekat self-assigned this Sep 7, 2021
@mattiekat
Copy link
Contributor

We discussed this internally and at least for now we will add serde behind a flag for the Rust implementation, but we do not plan on implementing for other languages as it is non-trivial and out-of-scope.

With that said, I am going update this issue to track the serde support and not JSON support more widely. If you still want the full scope of the original ticket to be captured, please open a new ticket.

@mattiekat mattiekat changed the title Support json Support serde in the rust implementation Sep 8, 2021
@mattiekat
Copy link
Contributor

This issue is blocked by #153

I ran into a challenge almost immediately with the SliceWrapper type and since there is already an open discussion around how to better handle lists and borrowing I am going to hold off on making a band-aid solution.

@mattiekat mattiekat removed their assignment May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants