Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: func config envs - interactive prompt #396

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

zroubalik
Copy link
Contributor

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Interactive prompt for managing function configuration - this PR adds Environment variables

func config envs - list configured Environment variables

func config envs add- starts interactive prompt, wizard that let's you add Environment variable to the configuration. It does a lookup for existing Secrets and ConfigMaps in the cluster and namespace.

func config envs remove

  • starts interactive prompt, wizard that let's you remove Environment variable from the configuration.

Relates: #362

config_envs.mp4

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
One thing I did not mention earlier, but may bear at least highlighting, is that with the addition of these interactive commands which hit the kubernetes API, our CLI is now coupled with the kubernetes API (rather than having that clean layer of func in between). But I am conflicted if this is really an existential problem, as it is coupling in order to ease the creation of that clean intermediary layer.

Just worth mentioning I suppose, because it provides a good example of challenging my desire to maintin the "purity" of the CLI, but for a clearly user-assisting reason.

@zroubalik
Copy link
Contributor Author

Looks good to me!
One thing I did not mention earlier, but may bear at least highlighting, is that with the addition of these interactive commands which hit the kubernetes API, our CLI is now coupled with the kubernetes API (rather than having that clean layer of func in between). But I am conflicted if this is really an existential problem, as it is coupling in order to ease the creation of that clean intermediary layer.

Just worth mentioning I suppose, because it provides a good example of challenging my desire to maintin the "purity" of the CLI, but for a clearly user-assisting reason.

You are right, I had the same concern, but I think that this is inevitable given the fact that we are going to part of Knative 🤷‍♂️

@lance
Copy link
Member

lance commented Jun 18, 2021

You are right, I had the same concern, but I think that this is inevitable given the fact that we are going to part of Knative

True - but it would be nice ultimately to have something like grid that proxies these API calls to Kube/Knative or some other platform. But for now going directly against the API is fine I suppose.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - sorry about the prompt impl Luke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants