Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "no_std" + "nightly" features and support no_std on stable #111

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

brycx
Copy link
Member

@brycx brycx commented Nov 18, 2019

subtle has added optimization barriers on stable Rust, in version 2.2.1. The reason we had a nightly feature before was to take advantage of these barriers, that were only available on nightly at the time.

This PR removes both no_std and nightly features in orion, making the crate-feature story a lot more simple. This enables using orion with no_std on both stable and nightly Rust (nightly is required for no_std now), only needing to specify orion = { version = "*", default-features = false }.

@brycx brycx added dependencies Issues or improvements related to used dependencies breaking change A breaking change labels Nov 18, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #111 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   97.37%   97.45%   +0.08%     
==========================================
  Files          48       48              
  Lines        6168     6168              
==========================================
+ Hits         6006     6011       +5     
+ Misses        162      157       -5
Impacted Files Coverage Δ
src/hazardous/stream/xchacha20.rs 92.85% <0%> (-1.43%) ⬇️
src/hazardous/kdf/hkdf.rs 98.83% <0%> (-1.17%) ⬇️
src/hazardous/aead/streaming.rs 98.42% <0%> (+0.19%) ⬆️
src/hazardous/stream/chacha20.rs 95.91% <0%> (+0.27%) ⬆️
src/aead.rs 100% <0%> (+1.2%) ⬆️
src/auth.rs 100% <0%> (+1.81%) ⬆️
src/kdf.rs 100% <0%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95bfbc9...95c6645. Read the comment docs.

@brycx brycx merged commit 0b4e642 into master Dec 2, 2019
@brycx brycx deleted the features branch December 2, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A breaking change dependencies Issues or improvements related to used dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant