Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested BackPressHandlers are ignored after app goes to background #60

Closed
steelahhh opened this issue Aug 11, 2022 · 1 comment · Fixed by #32
Closed

Nested BackPressHandlers are ignored after app goes to background #60

steelahhh opened this issue Aug 11, 2022 · 1 comment · Fixed by #32
Labels
bug Something isn't working

Comments

@steelahhh
Copy link

steelahhh commented Aug 11, 2022 •
edited
Loading

Haven't investigated the specifics, but here's the gist:

  • Have a ParentNode with BackStack or Modals that has a leaf ParentNode that also has BackStack
  • Push node to a nested BackStack
  • Put the app in background
  • Open the app
  • Only the root BackPressHandler is called

Can be reproduced in sandbox app in "Combined routing source" or "Modal example" or "Spotlight example"

Edit: Looks like this would be fixed by #32 🤔
@CherryPerry
Copy link
Collaborator

Thanks for your report.
I checked the cases you provided in sandbox app and looks like my PR actually fixes it.

@CherryPerry CherryPerry linked a pull request Aug 11, 2022 that will close this issue
BackPressHandler plugin #32
Merged
2 tasks
@LachlanMcKee LachlanMcKee added the bug Something isn't working label Aug 13, 2022
@steelahhh steelahhh mentioned this issue Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BackPressHandler plugin bumble-tech/appyx
3 participants
@LachlanMcKee @CherryPerry @steelahhh