From 2d91cfa89023c8f8f8d43ee2f215416c3fbd09c1 Mon Sep 17 00:00:00 2001 From: tanjadegroot <87864067+tanjadegroot@users.noreply.github.com> Date: Fri, 26 Jul 2024 14:02:10 +0200 Subject: [PATCH 1/4] Update issue_review_template.md --- .../ISSUE_TEMPLATE/issue_review_template.md | 21 ++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/issue_review_template.md b/.github/ISSUE_TEMPLATE/issue_review_template.md index 1ac39ab..3fbdaca 100644 --- a/.github/ISSUE_TEMPLATE/issue_review_template.md +++ b/.github/ISSUE_TEMPLATE/issue_review_template.md @@ -10,12 +10,11 @@ assignees: '' **Release PR or issue to review** -**Reviewer actions** +**Review actions** -To review, assign this issue to yourself and follow the below list. -For any item, review the file(s) in the issue/PR listed above. -Put comments in the above issue or PR if they concern non-changed text. -When done, tick the box in this issue. +Assign this issue to yourself and follow the below list. +For any review action, review the file(s) in the issue/PR listed above. +Put comments in the above issue or PR if they concern non-changed files/text. - [ ] API definition files (YAML) (check version in info & servers objects) - [ ] test file(s) availability @@ -23,5 +22,17 @@ When done, tick the box in this issue. - [ ] readme updated (enforce correct release number / API version naming) - [ ] API readiness checklist(s) +**Release actions** + +Assign this issue to yourself or another RM team member and follow the below list. +When done, tick the box in this issue. + +- [ ] API release tracker available on wiki +- [ ] Review comments addressed (by Sub Project) +- [ ] Release PR approved (on behalf of Release Management) +- [ ] PR merged (by Sub Project codeowner) +- [ ] Release created within GitHub (by Sub Project codeowner) +- [ ] Release Tracker updated (wuth creation date of the release) + **Additional comments** From d0ec4289f6ca3cd7848df490b0ac479e4009a74e Mon Sep 17 00:00:00 2001 From: tanjadegroot <87864067+tanjadegroot@users.noreply.github.com> Date: Fri, 26 Jul 2024 17:55:19 +0200 Subject: [PATCH 2/4] Update issue_review_template.md typo --- .github/ISSUE_TEMPLATE/issue_review_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/issue_review_template.md b/.github/ISSUE_TEMPLATE/issue_review_template.md index 3fbdaca..6804580 100644 --- a/.github/ISSUE_TEMPLATE/issue_review_template.md +++ b/.github/ISSUE_TEMPLATE/issue_review_template.md @@ -32,7 +32,7 @@ When done, tick the box in this issue. - [ ] Release PR approved (on behalf of Release Management) - [ ] PR merged (by Sub Project codeowner) - [ ] Release created within GitHub (by Sub Project codeowner) -- [ ] Release Tracker updated (wuth creation date of the release) +- [ ] Release Tracker updated (with creation date of the release) **Additional comments** From be52ba025bf0fee946e9fecad4908191d35a2bd4 Mon Sep 17 00:00:00 2001 From: tanjadegroot <87864067+tanjadegroot@users.noreply.github.com> Date: Fri, 26 Jul 2024 18:43:37 +0200 Subject: [PATCH 3/4] Update .github/ISSUE_TEMPLATE/issue_review_template.md Co-authored-by: Herbert Damker --- .github/ISSUE_TEMPLATE/issue_review_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/issue_review_template.md b/.github/ISSUE_TEMPLATE/issue_review_template.md index 6804580..9e11d65 100644 --- a/.github/ISSUE_TEMPLATE/issue_review_template.md +++ b/.github/ISSUE_TEMPLATE/issue_review_template.md @@ -15,6 +15,7 @@ assignees: '' Assign this issue to yourself and follow the below list. For any review action, review the file(s) in the issue/PR listed above. Put comments in the above issue or PR if they concern non-changed files/text. +Put a short summary of the main review result here into the review issue. - [ ] API definition files (YAML) (check version in info & servers objects) - [ ] test file(s) availability From 5aef14af29ea9b830828b1417d4700c0e565096c Mon Sep 17 00:00:00 2001 From: tanjadegroot <87864067+tanjadegroot@users.noreply.github.com> Date: Fri, 26 Jul 2024 19:25:50 +0200 Subject: [PATCH 4/4] Update issue_review_template.md tweek --- .github/ISSUE_TEMPLATE/issue_review_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/issue_review_template.md b/.github/ISSUE_TEMPLATE/issue_review_template.md index 9e11d65..40bcb87 100644 --- a/.github/ISSUE_TEMPLATE/issue_review_template.md +++ b/.github/ISSUE_TEMPLATE/issue_review_template.md @@ -33,7 +33,7 @@ When done, tick the box in this issue. - [ ] Release PR approved (on behalf of Release Management) - [ ] PR merged (by Sub Project codeowner) - [ ] Release created within GitHub (by Sub Project codeowner) -- [ ] Release Tracker updated (with creation date of the release) +- [ ] Release Tracker updated (with creation date of the release and the release tag link) **Additional comments**