Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing tab structure for OS DX #345

Closed
wants to merge 1 commit into from
Closed

Testing tab structure for OS DX #345

wants to merge 1 commit into from

Conversation

akeller
Copy link
Member

@akeller akeller commented Aug 25, 2021

Testing some structural improvements for cross-OS compatibility without crowding the docs!

@christinaausley
Copy link
Contributor

I really like how these tabs look on the page -- super clean without listing every option out on the same page.

@akeller
Copy link
Member Author

akeller commented Sep 9, 2021

We'll want to standardize on when to use tabs - should we say if there is more than one option? Two options? I see this being useful for programming language examples too.

@christinaausley
Copy link
Contributor

@akeller Discussed this in our 1:1 yesterday but commenting here for documentation purposes -- I like tabs for any more than one option given the cleanliness of the display.

@camunda-cloud-bot
Copy link

@akeller: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akeller
Copy link
Member Author

akeller commented Oct 14, 2021

Closing this PR, but we plan to add tabs for multi-OS instruction across our docs after the Docs Vision work is achieved.

@akeller akeller closed this Oct 14, 2021
@akeller akeller deleted the os-tab-test branch October 14, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants