Made label text for camel case or dash separated field names format nicely #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ var forms = require('./forms'), | |||
| return copy; | |||
| }, {}); | |||
| }, | |||
| underscoreRegExp = /_/g; | |||
| underscoreRegExp = /[_-]/g; | |||
There was a problem hiding this comment.
let's rename this variable since it's not just checking underscores
ljharb
added a commit
that referenced
this pull request
Jan 15, 2014
Made label text for camel case or dash separated field names format nicely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made is so if a user uses camel case or dash separated field names the label text adds spaces in between the words.
I made the replace method for fixing camel case field names use a function so that the first letter of the second word is lower cased to be consistent with the other use cases.