Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tabset panels #32

Closed
zkamvar opened this issue May 6, 2022 · 1 comment · Fixed by #121
Closed

Add support for tabset panels #32

zkamvar opened this issue May 6, 2022 · 1 comment · Fixed by #121
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zkamvar
Copy link
Contributor

zkamvar commented May 6, 2022

As mentioned in carpentries/workbench#5, having a tabset panel would be a nice feature for the workbench (and indeed we had it templated in figma, but it was never implemented 🙀.

Tabsets are available in bootstrap and we just need to figure out how to get the content to behave the way we want it to.

Things to be aware of

I believe that what we need to do is to add JavaScript and CSS elements, but we may also need to add extra lua filtering in {sandpaper}

@astroDimitrios
Copy link
Contributor

I have opened up pull requests adding in tabs / tabset panels and welcome any feedback:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants