-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inclusion of Matomo optional #37
Comments
For clarity, the matomo code you refer to exists here: varnish/inst/pkgdown/templates/footer.html Lines 33 to 51 in e9f5f87
@fmichonneau contributed this and can speak to how it works, but from what I understand it will only collect if a site is hosted on one of our official sites. The move to matomo was a strategic move to ensure that our lessons aligned with our privacy policy, which conforms to GDPR and CCPA. For what it's worth, this is not different to how the styles template is implemented. Would it help if I included an optional yaml item in something like this to set the analytics to nothing: analytics: '<!-- no analytics -->' or like this to use your own analytics code. analytics: |
<!-- Global site tag (gtag.js) - Google Analytics -->
<script async src="https://www.googletagmanager.com/gtag/js?id={YOUR TRACKING ID}"#' ></script>
<script>
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());
gtag('config', '{YOUR TRACKING ID}');
</script> |
I found the code and it looked like it would only work on certain domains (as you now confirm). However, I think it would save users not belonging to the Carpentries some trouble, if they would not even have to think about it. So an option like you suggest would be really helpful. To prevent repetition in Carpentries hosted lessons you could have three options: none, carpentries, |
Hi @fiveop, sorry to take so long to address this. A while ago, I excluded the matomo code completely for the lesson and so there is no tracking at all. I think your solution fits well and I will implement it in May. |
Just got the notification this was closed. Well done, @froggleston! It turns out that I didn't specify which May it would get implemented in 😅 |
Currently, Matomo is always included when someone uses varnish. If the workbench is supposed to be used like the old template, in particular for lesson material listed on the community lessons, there will be other legal entities than the Carpentries that are responsible for hosting pages generated by the workbench suite. As it stands they have no option, but to include the Matomo tracking/analytics script. At least in the EU, to be diligent, they should check what kind of data this collects and I am not sure whether that is possible for anyone but the Carpentries.
The text was updated successfully, but these errors were encountered: