feat: replace picomatch with minimatch #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zxilly @Shivansh-yadav13 please review |
nodece
force-pushed
the
replace_picomatch
branch
from
b4af6cb
to
cfa18d7
Compare
hsluoyz
approved these changes
Mar 20, 2023
hsluoyz
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
# [5.25.0](v5.24.4...v5.25.0) (2023-03-20) ### Features * replace picomatch with minimatch ([#440](#440)) ([4e977b3](4e977b3))
|
🎉 This PR is included in version 5.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
If pattern is "*", new implementation will lead to index out of range. |
When the pattern is "*", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #386
Replace: #393
Motivation
The picomatch cannot be running in the browser, so use the mininmatch instead of the picomatch.