Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blob): add fixes along with the fuzzers that discovered them #3732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(blob): add fixes along with the fuzzers that discovered them #3732

wants to merge 1 commit into from

Conversation

odeke-em
Copy link

This changes adds fuzzers+corpra that found some bugs,
along with tests and reproducers to catch future regressions.

Fixes #3727
Fixes #3728
Fixes #3729
Fixes #3730
Fixes #3731

@github-actions github-actions bot added the external Issues created by non node team members label Sep 16, 2024
This was referenced Sep 16, 2024
Open
Open
Open
rach-id
rach-id reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catches 👍

blob/repro_test.go Outdated Show resolved Hide resolved
@odeke-em
fix(blob): add fixes along with the fuzzers that discovered them
6f6b900 
This changes adds fuzzers+corpra that found some bugs, along
with tests and reproducers to catch future regressions.

Fixes celestiaorg#3727
Fixes celestiaorg#3728
Fixes celestiaorg#3729
Fixes celestiaorg#3730
Fixes celestiaorg#3731
Wondertan
Wondertan approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (2469e7a) to head (6f6b900).
Report is 191 commits behind head on main.

Files with missing lines Patch % Lines
blob/commitment_proof.go 38.46% 5 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3732      +/-   ##
==========================================
+ Coverage   44.83%   45.65%   +0.82%     
==========================================
  Files         265      281      +16     
  Lines       14620    16047    +1427     
==========================================
+ Hits         6555     7327     +772     
- Misses       7313     7877     +564     
- Partials      752      843      +91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristaloleg cristaloleg added the kind:testing Related to unit tests label Sep 16, 2024
@Wondertan Wondertan enabled auto-merge (squash) September 18, 2024 20:35
@Wondertan
Copy link
Member

@odeke-em, do you mind fixing linter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walldiss walldiss walldiss approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@rach-id rach-id Awaiting requested review from rach-id

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

Assignees

@odeke-em odeke-em

Labels
external Issues created by non node team members kind:testing Related to unit tests
Projects
None yet
Milestone
No milestone
7 participants
@odeke-em @codecov-commenter @Wondertan @cristaloleg @walldiss @rach-id @vgonkivs