-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension name with more than 20 characters throws error #670
Comments
It should be possible. Good point. What version of the sdk are you seeing this in? it is in the latest 2.4.0? |
We experienced it first with the 2.4.0 release. I think it might have sneaked in with this commit. |
Yep. ok thanks! I will get a point fix release out in the next couple days. |
Thank you. If it is only about removing the length check, I can come up with a little PR, too. |
@deissnerk If you want to write the PR, that would be great, I was thinking of having a global setting that an importer can set the max length to something they wish, but have the default be unlimited (0). |
SetExtension()
of the v1.0 event context throws an error, if the name of the extension is longer than 20 characters. In the spec this length restriction is a SHOULD NOT restriction. So failing with an error seems to be too strong. Shouldn't it be possible to violate SHOULD requirements? 😉The text was updated successfully, but these errors were encountered: