Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension name with more than 20 characters throws error #670

Open
deissnerk opened this issue Apr 8, 2021 · 5 comments
Open

Extension name with more than 20 characters throws error #670

deissnerk opened this issue Apr 8, 2021 · 5 comments

Comments

@deissnerk
Copy link
Contributor

SetExtension() of the v1.0 event context throws an error, if the name of the extension is longer than 20 characters. In the spec this length restriction is a SHOULD NOT restriction. So failing with an error seems to be too strong. Shouldn't it be possible to violate SHOULD requirements? 😉

@n3wscott
Copy link
Member

n3wscott commented Apr 8, 2021

It should be possible. Good point. What version of the sdk are you seeing this in? it is in the latest 2.4.0?

@deissnerk
Copy link
Contributor Author

We experienced it first with the 2.4.0 release. I think it might have sneaked in with this commit.

@n3wscott
Copy link
Member

n3wscott commented Apr 9, 2021

Yep. ok thanks! I will get a point fix release out in the next couple days.

@deissnerk
Copy link
Contributor Author

Thank you. If it is only about removing the length check, I can come up with a little PR, too.

@n3wscott
Copy link
Member

@deissnerk If you want to write the PR, that would be great, I was thinking of having a global setting that an importer can set the max length to something they wish, but have the default be unlimited (0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants