From b44013f9da783ca36763900459c2e8729f8ae021 Mon Sep 17 00:00:00 2001
From: mmusich <marco.musich@cern.ch>
Date: Sun, 11 Feb 2024 18:20:35 +0100
Subject: [PATCH] add unit tests for ZMuMuMassConstraintParameterFinder and
 rename some unit tests

---
 .../test/BuildFile.xml                        | 11 +++++++---
 .../printParameters.C                         | 21 +++++++++++++++++++
 .../test/testFindMassContraintParameters.cpp  |  5 +++++
 ...test_ZMuMuMassConstraintParameterFinder.sh |  4 ++++
 4 files changed, 38 insertions(+), 3 deletions(-)
 create mode 100644 Alignment/MillePedeAlignmentAlgorithm/test/testFindMassContraintParameters.cpp
 create mode 100755 Alignment/MillePedeAlignmentAlgorithm/test/test_ZMuMuMassConstraintParameterFinder.sh

diff --git a/Alignment/MillePedeAlignmentAlgorithm/test/BuildFile.xml b/Alignment/MillePedeAlignmentAlgorithm/test/BuildFile.xml
index 9a1f8a9757530..e0cbb57420c02 100644
--- a/Alignment/MillePedeAlignmentAlgorithm/test/BuildFile.xml
+++ b/Alignment/MillePedeAlignmentAlgorithm/test/BuildFile.xml
@@ -10,7 +10,12 @@
 <test name="test-pede" command="pede -t">
   <use name="millepede"/>
 </test>
-<test name="testPedeCampaign" command="test_pede.sh"/>
-<test name="testPayloadSanity" command="test_payload_sanity.sh">
-  <flags PRE_TEST="testPedeCampaign"/>
+<test name="test_PedeCampaign" command="test_pede.sh"/>
+<test name="test_PayloadSanity" command="test_payload_sanity.sh">
+  <flags PRE_TEST="test_PedeCampaign"/>
 </test>
+<test name="test_ZMuMuMassConstraintParameterFinder" command="test_ZMuMuMassConstraintParameterFinder.sh"/>
+<bin file="testFindMassContraintParameters.cpp" name="test_ExtractMassConstraint">
+  <flags PRE_TEST="test_ZMuMuMassConstraintParameterFinder"/>
+  <use name="rootcore"/>
+</bin>
diff --git a/Alignment/MillePedeAlignmentAlgorithm/test/ZMuMuMassConstraintParameterFinder/printParameters.C b/Alignment/MillePedeAlignmentAlgorithm/test/ZMuMuMassConstraintParameterFinder/printParameters.C
index 3c95b40703ea9..c51468c2fcce2 100644
--- a/Alignment/MillePedeAlignmentAlgorithm/test/ZMuMuMassConstraintParameterFinder/printParameters.C
+++ b/Alignment/MillePedeAlignmentAlgorithm/test/ZMuMuMassConstraintParameterFinder/printParameters.C
@@ -1,4 +1,23 @@
+#include <TFile.h>
+#include <TTree.h>
+#include <TPad.h>
+#include <TH1F.h>
+#include <iostream>
+
+bool isValidFile(const TString& fileName) {
+  TFile* file = TFile::Open(fileName, "read");
+  if (!file || file->IsZombie()) {
+    std::cout << "Error: Invalid file or file is a zombie.\n";
+    return false;
+  }
+  return true;
+}
+
 void printParameters(const TString& fileName) {
+  if (!isValidFile(fileName)) {
+    exit(EXIT_FAILURE);
+  }
+
   TFile* file = TFile::Open(fileName, "read");
   TTree* tree = static_cast<TTree*>(file->Get("zMuMuMassConstraintParameterFinder/di_muon_from_Z"));
   tree->Draw("di_muon_mass>>htemp", "in_mass_window");
@@ -10,4 +29,6 @@ void printParameters(const TString& fileName) {
   std::cout << "  PrimaryMass  = " << htemp->GetMean() << "\n";
   std::cout << "  PrimaryWidth = " << htemp->GetRMS() << "\n";
   std::cout << "========================================\n";
+
+  exit(EXIT_SUCCESS);
 }
diff --git a/Alignment/MillePedeAlignmentAlgorithm/test/testFindMassContraintParameters.cpp b/Alignment/MillePedeAlignmentAlgorithm/test/testFindMassContraintParameters.cpp
new file mode 100644
index 0000000000000..97bb663a05352
--- /dev/null
+++ b/Alignment/MillePedeAlignmentAlgorithm/test/testFindMassContraintParameters.cpp
@@ -0,0 +1,5 @@
+#include <iostream>
+#include <sstream>
+#include "Alignment/MillePedeAlignmentAlgorithm/test/ZMuMuMassConstraintParameterFinder/printParameters.C"
+
+int main(int argc, char** argv) { printParameters("output.root"); }
diff --git a/Alignment/MillePedeAlignmentAlgorithm/test/test_ZMuMuMassConstraintParameterFinder.sh b/Alignment/MillePedeAlignmentAlgorithm/test/test_ZMuMuMassConstraintParameterFinder.sh
new file mode 100755
index 0000000000000..a46fcb76272db
--- /dev/null
+++ b/Alignment/MillePedeAlignmentAlgorithm/test/test_ZMuMuMassConstraintParameterFinder.sh
@@ -0,0 +1,4 @@
+#!/bin/bash
+function die { echo $1: status $2; exit $2; }
+
+(cmsRun ${SCRAM_TEST_PATH}/ZMuMuMassConstraintParameterFinder/zmumudistribution_cfg.py inputFiles=/store/relval/CMSSW_14_0_0_pre2/RelValZMM_14/GEN-SIM/133X_mcRun3_2024_realistic_v5_STD_2024_PU-v1/2590000/c38cee3f-99d7-48aa-b236-86f6bbc869b3.root,/store/relval/CMSSW_14_0_0_pre2/RelValZMM_14/GEN-SIM/133X_mcRun3_2024_realistic_v5_STD_2024_PU-v1/2590000/5bf98cca-d491-4e95-98b0-d3acb6ea0807.root,/store/relval/CMSSW_14_0_0_pre2/RelValZMM_14/GEN-SIM/133X_mcRun3_2024_realistic_v5_STD_2024_PU-v1/2590000/1e362cc1-235b-4c32-bb24-178ccac4659f.root) || die 'failed running ZMuMuMassConstraintParameterFinder' $?