From b6a92981a85931473e3151af55683d08beed21c2 Mon Sep 17 00:00:00 2001
From: mmusich <marco.musich@cern.ch>
Date: Thu, 11 Apr 2024 09:39:54 +0200
Subject: [PATCH] ShortenedTrackValidation: fix plot ranges and input original
 track collection

---
 .../plugins/ShortenedTrackValidation.cc       | 26 +++++++++----------
 .../test/testShortenedTrackValidation_cfg.py  |  2 +-
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/Alignment/OfflineValidation/plugins/ShortenedTrackValidation.cc b/Alignment/OfflineValidation/plugins/ShortenedTrackValidation.cc
index d606dd6f2704d..34c5f474b0c40 100644
--- a/Alignment/OfflineValidation/plugins/ShortenedTrackValidation.cc
+++ b/Alignment/OfflineValidation/plugins/ShortenedTrackValidation.cc
@@ -415,9 +415,9 @@ void ShortenedTrackValidation::beginJob() {
                    fmt::sprintf("Short Track p_{T} / Full Track p_{T} - %s layers;p_{T}^{short}/p_{T}^{full};n. tracks",
                                 hitsRemain_[i])
                        .c_str(),
-                   101,
-                   -0.05,
-                   2.05));
+                   100,
+                   0.5,
+                   1.5));
 
     histsPtDiffAll_.push_back(book<TH1F>(
         ShortTrackResolution,
@@ -436,8 +436,8 @@ void ShortenedTrackValidation::beginJob() {
                                 hitsRemain_[i])
                        .c_str(),
                    100,
-                   -0.01,
-                   0.01));
+                   -0.001,
+                   0.001));
 
     histsPhiDiffAll_.push_back(
         book<TH1F>(ShortTrackResolution,
@@ -446,8 +446,8 @@ void ShortenedTrackValidation::beginJob() {
                                 hitsRemain_[i])
                        .c_str(),
                    100,
-                   -0.01,
-                   0.01));
+                   -0.001,
+                   0.001));
 
     histsPtRatioVsDeltaRAll_.push_back(
         book<TH2F>(ShortTrackResolution,
@@ -471,16 +471,16 @@ void ShortenedTrackValidation::beginJob() {
                                 hitsRemain_[i])
                        .c_str(),
                    101,
-                   -10.,
-                   10.));
+                   -5.,
+                   5.));
 
     histsPtAll_.push_back(
         book<TH1F>(TrackQuals,
                    fmt::sprintf("trackPt_%s", hitsRemain_[i]).c_str(),
                    fmt::sprintf("Short Track p_{T} - %s layers;p_{T}^{short} [GeV];n. tracks", hitsRemain_[i]).c_str(),
-                   101,
-                   -0.05,
-                   200.5));
+                   100,
+                   0.,
+                   100.));
 
     histsNhitsAll_.push_back(
         book<TH1F>(TrackQuals,
@@ -496,7 +496,7 @@ void ShortenedTrackValidation::beginJob() {
         fmt::sprintf("Short Track / Long Track #DeltaR %s layers;#DeltaR(short,long);n. tracks", hitsRemain_[i]).c_str(),
         100,
         0.,
-        0.01));
+        0.005));
 
     currentFolder = fmt::sprintf("%s/Compare_%sHit", folderName_, hitsRemain_[i]);
     comparators_[i]->book(fs_->mkdir(currentFolder));
diff --git a/Alignment/OfflineValidation/test/testShortenedTrackValidation_cfg.py b/Alignment/OfflineValidation/test/testShortenedTrackValidation_cfg.py
index 2901ef5a7fc83..4238cbd9cda3d 100644
--- a/Alignment/OfflineValidation/test/testShortenedTrackValidation_cfg.py
+++ b/Alignment/OfflineValidation/test/testShortenedTrackValidation_cfg.py
@@ -118,7 +118,7 @@
                                                                    minTracksPtInput     = 15.0,
                                                                    maxTracksPtInput     = 99999.9,
                                                                    maxDrInput           = 0.01,
-                                                                   tracksInputTag       = "SingleLongTrackProducer",
+                                                                   tracksInputTag       = "LongTracksRefit",  # input original track should be refit  
                                                                    tracksRerecoInputTag = ["RefittedShortTracks3",
                                                                                            "RefittedShortTracks4",
                                                                                            "RefittedShortTracks5",