Bug in L1TStage2EMTF

[Dr15Jones]

UBSAN reported

114 DQM/L1TMonitor/src/L1TStage2EMTF.cc:1009:59: runtime error: index 2 out of bounds for type 'MonitorElement *[2]'

which corresponds to

cmssw/DQM/L1TMonitor/src/L1TStage2EMTF.cc

Line 1009 in 6d26b89

gemVFATBXPerChamber[chamber - 1][hist_index][layer]->Fill(Hit->BX(), vfat);

and the member data is defined here

cmssw/DQM/L1TMonitor/interface/L1TStage2EMTF.h

Line 119 in 6d26b89

MonitorElement* gemVFATBXPerChamber[36][2][2];

where the variable layer is defined here

cmssw/DQM/L1TMonitor/src/L1TStage2EMTF.cc

Line 1001 in 6d26b89

int layer = Hit->Layer();

and comes from the member data of the hit here

cmssw/DataFormats/L1TMuon/interface/EMTFHit.h

Line 352 in 6d26b89

int layer; ///< 0 - 1. For GEMs only, superchamber detector layer (1 or 2).

NOTE that the comment above says layer can be value 2.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @Dr15Jones.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign DQM/L1TMonitor

[cmsbuild]

New categories assigned: dqm

@antoniovagnerini,@nothingface0,@rvenditti,@syuvivida,@tjavaid you have been requested to review this Pull request/Issue and eventually sign? Thanks

[makortel]

@cms-sw/l1-l2

[aloeliger]

@eyigitba

[eyigitba]

I just got back from vacation. I'll have a look at this soon