Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM Analyzer][DQM] Dead assignment in BrilClient.cc #46234

Open
iarspider opened this issue Oct 3, 2024 · 4 comments
Open

[LLVM Analyzer][DQM] Dead assignment in BrilClient.cc #46234

iarspider opened this issue Oct 3, 2024 · 4 comments
Labels
dqm-pending pending-signatures

Comments

@iarspider
Copy link
Contributor

LLVM Analyzer reports dead assignment in BrilClient.cc.

Indeed, if igetter_.get returns nullptr, then the code just creates 2D histogram name, but doesn't add th content to it. Also, code on L93 seems suspicious - maybe it should be m->getTH2F()->Add(th);? (TH2F instead of TH1F)
@iarspider
Copy link
Contributor Author

assign dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

New categories assigned: dqm

@antoniovagnerini,@nothingface0,@rvenditti,@syuvivida,@tjavaid you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dqm-pending pending-signatures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iarspider @cmsbuild