Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid controls design #6489

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Grid controls design #6489

merged 7 commits into from
Oct 9, 2024

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Oct 7, 2024

Making some improvements to the visual design of canvas grid controls

  • grid gap handles and canvas labels, are orange to match the orange overlay pattern
  • grid row/column resize handles are now labels with their width (replacing the <-> arrows)
  • grid row/column area names are now inside the highlight overlay when being resized
  • grid/row highlight is now a blue pattern instead of pink

image
image
image
image

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Try me

Copy link

relativeci bot commented Oct 7, 2024

#14652 Bundle Size — 57.74MiB (~-0.01%).

f504dbe(current) vs 916e8b9 master#14647(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#14652
     Baseline
#14647
Improvement  Initial JS 40.74MiB(~-0.01%) 40.74MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 17.97% 17.95%
No change  Chunks 21 21
No change  Assets 23 23
No change  Modules 4113 4113
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.41% 27.41%
No change  Packages 475 475
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#14652
     Baseline
#14647
Improvement  JS 57.73MiB (~-0.01%) 57.73MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch grid-controls-designProject dashboard


Generated by RelativeCIDocumentationReport issue

@lankaukk lankaukk marked this pull request as ready for review October 8, 2024 16:14
@balazsbajorics balazsbajorics merged commit 4cdb407 into master Oct 9, 2024
14 checks passed
@balazsbajorics balazsbajorics deleted the grid-controls-design branch October 9, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants