Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "insecure" opt-in for Trustee AS/KBS token signing/verification #486

Open
mythi opened this issue Aug 29, 2024 · 0 comments
Open

Add "insecure" opt-in for Trustee AS/KBS token signing/verification #486

mythi opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mythi
Copy link
Contributor

mythi commented Aug 29, 2024

Describe the bug

Triggered by #483.

It seems it's rather easy to create an insecure environment with the default configs where AS token signer material and/or KBS tokenverifier ‎trusted_certs_paths are not set.

The proposal is to add an "insecure" opt-in similar to how the existing insecure_* switches work to at least in the tokenverifier to fail tokens if the opt-in is not enabled.

How to reproduce

Run Trustee KBS with one of the default kbs/config/*.toml without trusted_certs_paths. With that, the following takes place

let Some(trusted_store) = &self.trusted_certs else {
log::warn!("No Trusted Certificate in Config, skip verification of JWK cert of Attestation Token");
return Ok(serde_json::to_string(&claims_value)?);
};

CoCo version information

trustee v0.9.0

What TEE are you seeing the problem on

None

Failing command and relevant log output

N/A
@mythi mythi added the bug Something isn't working label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant