-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass status along ipam update #1082
base: main
Are you sure you want to change the base?
Pass status along ipam update #1082
Conversation
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
The `skel.PluginMain` functions were deprecated in CNI v1.2.0. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
} | ||
} | ||
|
||
// TODO: Check if hode device exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awkward -- you're right, the host device does not exist anymore, but it may have been moved with an ADD. I worry this could cause more trouble than its worth. Hmm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the miss-spelling.
The idea comes from this comment: #1021 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!!!
Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
a33a4c8
to
aea27c7
Compare
@LionelJouin you need to be rebase |
64a1ec5
to
044df64
Compare
044df64
to
c5883a2
Compare
@LionelJouin needs another rebase :-) |
@LionelJouin somehow this PR still does not have the green button. Perhaps the latest changes to Can you rebase and drop your merge commit? That helps keep the history clean. |
This PR fixes the missing parts of #1050 (pass STATUS to a delegated plugin)
I also updated the cni dependency to v1.2.3