Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting issues #14981

Closed
julienrbrt opened this issue Feb 9, 2023 · 2 comments · Fixed by #15062
Closed

Fix linting issues #14981

julienrbrt opened this issue Feb 9, 2023 · 2 comments · Fixed by #15062
Assignees
@facundomedica
Labels
good first issue help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Feb 9, 2023 •
edited
Loading

The SDK uses golangci-lint for its linting.
Recently, due to the bump of the minimum version to Go 1.20, the golangci-lint version has been bumped to a version that supports Go 1.20. Doing that surfaced a few linting issues that should be addressed: https://github.com/cosmos/cosmos-sdk/actions/runs/4136029232/jobs/7149298297.

To surface them and check which ones are left, run make lint-fix.
@julienrbrt julienrbrt added help wanted good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Feb 9, 2023
@SaumyaBhushan
Copy link

I will work on this one

@julienrbrt
Copy link
Member Author

I will work on this one

Thank you!

@julienrbrt julienrbrt linked a pull request Feb 17, 2023 that will close this issue
refactor: fix lint issues + gofumpt #15062
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundomedica facundomedica

Labels
good first issue help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: fix lint issues + gofumpt cosmos/cosmos-sdk
3 participants
@facundomedica @julienrbrt @SaumyaBhushan