Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cosmovisor tests on master #9919

Closed
4 tasks
amaury1093 opened this issue Aug 12, 2021 · 3 comments · Fixed by #9926 or #9929
Closed
4 tasks

Fix cosmovisor tests on master #9919

amaury1093 opened this issue Aug 12, 2021 · 3 comments · Fixed by #9926 or #9929
Assignees
Labels
C:Cosmovisor Issues and PR related to Cosmovisor T: Tests

Comments

@amaury1093
Copy link
Contributor

Summary of Bug

Fix failing cosmovisor test on master.

They are required in Github CI checks, so they are blocking PR merges.

Version

13559f9

Steps to Reproduce

Failing test: https://github.com/cosmos/cosmos-sdk/runs/3302246245


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba
Copy link
Collaborator

It looks it's a problem with the CI, locally it works.

@ryanchristo
Copy link
Contributor

It looks it's a problem with the CI, locally it works.

I'm able to reproduce locally:

[cosmovisor], error reading /tmp/TestProcessTestSuite_TestLaunchProcessWithDownloads2618285287/001/cosmovisor/current/upgrade-info.json lstat /tmp/TestProcessTestSuite_TestLaunchProcessWithDownloads2618285287/001/cosmovisor/current/upgrade-info.json: no such file or directory
--- FAIL: TestProcessTestSuite (2.94s)
    --- FAIL: TestProcessTestSuite/TestLaunchProcessWithDownloads (0.94s)
        process_test.go:92: 
            	Error Trace:	process_test.go:92
            	Error:      	Received unexpected error:
            	            	cannot download binary. bad response code: 404
            	Test:       	TestProcessTestSuite/TestLaunchProcessWithDownloads
FAIL

The issue is because you were using the feature branch for the download path. I think I have a fix.

@robert-zaremba
Copy link
Collaborator

I'm able to reproduce locally:

Right, I was testing it in my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor T: Tests
Projects
None yet
3 participants