Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to cosmos/gogoproto #2650

Closed
3 tasks
colin-axner opened this issue Nov 2, 2022 · 3 comments · Fixed by #2672
Closed
3 tasks

Migrate to cosmos/gogoproto #2650

colin-axner opened this issue Nov 2, 2022 · 3 comments · Fixed by #2672
Labels
dependencies Issues or PRs to update a dependency

Comments

@colin-axner
Copy link
Contributor

Summary

Migrate from gogo/protobuf to cosmos/gogoproto, ref issue and ref pr

Problem Definition

We are still using the go mod replace directive to unmaintained code

Proposal

Switch from the regen fork to the cosmos fork. I'm unsure how involved this work will be outside of updating imports


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

I think Simon is actually working on this as part of the upgrade to SDK 0.47. I will check with him.

@colin-axner
Copy link
Contributor Author

Lets bring it out as a separate pr, it doesn't need to wait for v0.47 correct?

@colin-axner colin-axner mentioned this issue Nov 7, 2022
9 tasks
@julienrbrt
Copy link
Member

Lets bring it out as a separate pr, it doesn't need to wait for v0.47 correct?

Unfortunately, it does. IBC depends on SDK 0.46, which still uses gogo/protobuf, so the proto.Message must be using gogo/protobuf.

@crodriguezvega crodriguezvega added this to the SDK v0.47.x upgrade milestone Nov 13, 2022
@crodriguezvega crodriguezvega added the dependencies Issues or PRs to update a dependency label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs to update a dependency
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants