Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new condition builder #80

Closed
4 tasks
lukeholder opened this issue Aug 14, 2017 · 2 comments
Closed
4 tasks

Add new condition builder #80

lukeholder opened this issue Aug 14, 2017 · 2 comments
Assignees
Labels
discussion 💡 enhancement Ideas and suggestions

Comments

@lukeholder
Copy link
Member

lukeholder commented Aug 14, 2017

Add condition builder for logical conditions.

Use in:

  • Discounts
  • Sales
  • Tax
  • Shipping

Will fix #181
Should fix #467

Look into https://dabernathy89.github.io/vue-query-builder/ ?

Condition and effects should be separated for discounts and sales so effected products/variants can be different from conditions.

@lukeholder
Copy link
Member Author

Instead of sales types or discount types, we should move to plugins providing condition objects we can use in a rules builder.

Conditions would really be like a fieldtype, but offer a way to match (true or false) an element

A condition object would provide:

inputHtml() like fields for the conditions params to be entered.
a list of elements the condition is compatible with
a match() method to match the condition with the element.

@lukeholder
Copy link
Member Author

Need to also be able to generate all combinations of sale prices for all matching purchasables for each sale, so that the hasSales param on the product/variant/purchasable query can be a simple join.

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
discussion 💡 enhancement Ideas and suggestions
Projects
None yet
Development

No branches or pull requests

3 participants