Problem: potentially unneeded, deprecated and legacy functions in use #345
Conversation
Solution: Removed legacy API from supply module and unused code from chainmain module. Fixes crypto-org-chain#338.
devashishdxt
requested review from
calvinaco,
leejw51crypto,
linfeng-crypto,
tomtau and
yihuang
as code owners
|
/runsim |
|
Simulation tests started and triggered by |
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 12.03% 12.13% +0.09%
==========================================
Files 35 32 -3
Lines 5349 5165 -184
==========================================
- Hits 644 627 -17
+ Misses 4453 4289 -164
+ Partials 252 249 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| func NewQuerier(k Keeper, legacyQuerierCdc *codec.LegacyAmino) sdk.Querier { | ||
| return func(ctx sdk.Context, path []string, req abci.RequestQuery) ([]byte, error) { | ||
| switch path[0] { | ||
| case types.QueryTotalSupply: |
There was a problem hiding this comment.
Are these queriers not used?
There was a problem hiding this comment.
I don't think so. @calvinaco can clarify.
There was a problem hiding this comment.
checked with @calvinaco -- this legacy one wasn't being used or planned to be used by third parties
|
✅ |
Solution: Removed legacy API from supply module and unused code from chainmain module. Fixes #338.