-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for android gradle plugin 8 #117
Conversation
<!-- Register Customer.io Firebase Messaging Service as we want our SDK to handle all push | ||
notifications --> | ||
<service | ||
android:name="io.customer.messagingpush.CustomerIOFirebaseMessagingService" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notifications were not working for Android apps, so I added Option 2 so our SDK handles everything in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks, can you also make sure Android devices are well registered with this update ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AristideVB, thanks for bringing this to our attention. Unfortunately, I haven’t dived into the details of shared issue yet, so I can't confirm immediately, but it seems related to Gradle 8 and its associated updates. While we're still verifying the changes with Gradle 8, we've also released an update recently which includes a fix with proguard rules for R8's strict mode. Can you please try version 1.3.2
and let us know if it resolves the issue for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mrehan27 I've just tested version 1.3.2 & it does seem to have resolved the issue #113 🙂
Thank you 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to hear. Thanks for confirming 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Adding the blocked label to wait until Android SDK gets merged its already added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking because of manifest file conversation. I think that the PR as it is now is not a backwards compatible change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team responded back to my concerns on backwards compatibility. Approved!
## [1.4.0](1.3.2...1.4.0) (2024-04-18) ### Features * support for android gradle plugin 8 ([#117](#117)) ([48b4e06](48b4e06))
closes: MBL-232
blocked by: release of customerio/customerio-android#296
Highlights
17
from1.8
Changes
Tasks