Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for android gradle plugin 8 #117

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Apr 9, 2024

closes: MBL-232
blocked by: release of customerio/customerio-android#296

Highlights

  • Support for Android Gradle Plugin 8.0
  • JDK Version is updated to 17 from 1.8

Changes

  • Updated flutter plugin to make it compatible with changes for Android Gradle Plugin 8.0 in native SDK
  • Updated sample app to use same gradle plugin version

Tasks

  • Update Android SDK version to actual required value

@mrehan27 mrehan27 self-assigned this Apr 9, 2024
@mrehan27 mrehan27 requested a review from a team April 9, 2024 07:09
<!-- Register Customer.io Firebase Messaging Service as we want our SDK to handle all push
notifications -->
<service
android:name="io.customer.messagingpush.CustomerIOFirebaseMessagingService"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notifications were not working for Android apps, so I added Option 2 so our SDK handles everything in it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks, can you also make sure Android devices are well registered with this update ?

#113

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AristideVB, thanks for bringing this to our attention. Unfortunately, I haven’t dived into the details of shared issue yet, so I can't confirm immediately, but it seems related to Gradle 8 and its associated updates. While we're still verifying the changes with Gradle 8, we've also released an update recently which includes a fix with proguard rules for R8's strict mode. Can you please try version 1.3.2 and let us know if it resolves the issue for you?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrehan27 I've just tested version 1.3.2 & it does seem to have resolved the issue #113 🙂

Thank you 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to hear. Thanks for confirming 👍🏻

Copy link
Collaborator

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Adding the blocked label to wait until Android SDK gets merged its already added.

Copy link
Contributor

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking because of manifest file conversation. I think that the PR as it is now is not a backwards compatible change.

Copy link
Contributor

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team responded back to my concerns on backwards compatibility. Approved!

@mrehan27 mrehan27 merged commit 48b4e06 into main Apr 18, 2024
5 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-232-agp-8 branch April 18, 2024 09:53
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
## [1.4.0](1.3.2...1.4.0) (2024-04-18)

### Features

* support for android gradle plugin 8 ([#117](#117)) ([48b4e06](48b4e06))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants