Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in case lack of objects while saving in AAM #3266

Closed
2 tasks done
TOsmanov opened this issue Jun 1, 2021 · 1 comment · Fixed by #3401
Closed
2 tasks done

Bug in case lack of objects while saving in AAM #3266

TOsmanov opened this issue Jun 1, 2021 · 1 comment · Fixed by #3401
Assignees
Labels
bug Something isn't working

Comments

@TOsmanov
Copy link
Contributor

TOsmanov commented Jun 1, 2021

My actions before raising this issue

Expected Behaviour

Saving the task without bugs.

Current Behaviour

If you save the task when the label of an object was changed in Attribute Annotation Mode with a filter applied to a specific label, then CVAT closes with the error “Oops, something went wrong”.

Possible Solution

Steps to Reproduce (for bugs)

  1. Add filter (example label == “label_name”)
  2. Change annotation mode to Attribute Annotation Mode
  3. Change the label to any other. Thus, there should be no objects that meet the filter.
  4. Save

Context

Saving occurs, but the bug forces you to reboot the page

Your Environment

  • Windows 10, Google Chrome,
  • Git hash commit (git log -1):
  • Docker version docker version (e.g. Docker 17.0.05):
  • Are you using Docker Swarm or Kubernetes?
  • Operating System and version (e.g. Linux, Windows, MacOS):
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    TypeError

Cannot read property 'objectType' of undefined

TypeError: Cannot read property 'objectType' of undefined
at Ew.activateOnCanvas (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:414:998304)
at Ew.componentDidUpdate (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:414:996061)
at os (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:352:83470)
at pl (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:352:101245)
at t.unstable_runWithPriority (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:360:3844)
at Ba (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:352:45023)
at fl (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:352:97717)
at Qs (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:352:93871)
at https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:352:45314
at t.unstable_runWithPriority (https://cvat.org/cvat-ui.619e2cab9c511e1a12c4.min.js:360:3844)

Next steps

You may join our Gitter channel for community support.

@bsekachev bsekachev self-assigned this Jun 1, 2021
@bsekachev bsekachev added the bug Something isn't working label Jun 1, 2021
@bsekachev
Copy link
Member

bsekachev commented Jul 8, 2021

Change the label to any other. Thus, there should be no objects that meet the filter.

Yes, it is true. But it was intended that after the object was changed it is still visible because of UX reasons (the change can be done accidentally or it is not finished yet when we are changing the text for example). In these cases, we should not immediately hide the object.

The issue fixed in the PR below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants